Ensure we only serialize IndexModes when they are available#149409
Open
benwtrent wants to merge 4 commits into
Open
Ensure we only serialize IndexModes when they are available#149409benwtrent wants to merge 4 commits into
benwtrent wants to merge 4 commits into
Conversation
elasticsearchmachine
added
serverless-linked
benwtrent
added
>bug
:Search Relevance/Vectors
elasticsearchmachine
added
the
Team:Search Relevance
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
This PR fixes potential NPEs that can arise from using an updates PIT id after relocation. The issue is currently guarded by a feature flag an setting and was only observed during testing. PIT id rewriting in AbstractSearchAsyncAction#maybeReEncodeNodeIds assumes that each SearchPhaseResult used to update the id has a set ShardSearchContextId. However, there are certain optimizations under which the data node might return a QuerySearchResult nullInstance() which doesn't contain a ShardSearchContextId. Using these results to update the PIT id leads to NPEs when using these ids in subsequent search requests. The PR fixes this issue by not using the results ShardSearchContextId but the original PIT ids context. Since only the target nodes change with PIT relocation and the context id remains fixed, this avoids running into the NPE issues. Closes elastic#149371
mayya-sharipova
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should only serialize stats for indexmodes that are available given the current feature flags.