Fix histogram isNotNullFilter CSV test capabilities#149308
Merged
Merged
Conversation
JonasKunz
added
>test
Collaborator
|
@JonasKunz please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation. |
elasticsearchmachine
added
external-contributor
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
kkrik-es
approved these changes
May 18, 2026
JonasKunz
added
v9.4.0
v9.4.2
auto-backport
Contributor
Author
|
9.0.8 BWC failures in CI should be unrelated, as histograms didn't exist in ES|QL back then. Removing the label and re-running the build to merge. |
quackaplop
approved these changes
May 18, 2026
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 19, 2026
benwtrent
pushed a commit
to benwtrent/elasticsearch
that referenced
this pull request
May 19, 2026
benwtrent
added a commit
that referenced
this pull request
May 19, 2026
* Ensure we only serialize IndexModes when they are available * Fix histogram isNotNullFilter CSV test capabilities (#149308) * Fix Potential of NPE in PIT search after relocation (#149375) This PR fixes potential NPEs that can arise from using an updates PIT id after relocation. The issue is currently guarded by a feature flag an setting and was only observed during testing. PIT id rewriting in AbstractSearchAsyncAction#maybeReEncodeNodeIds assumes that each SearchPhaseResult used to update the id has a set ShardSearchContextId. However, there are certain optimizations under which the data node might return a QuerySearchResult nullInstance() which doesn't contain a ShardSearchContextId. Using these results to update the PIT id leads to NPEs when using these ids in subsequent search requests. The PR fixes this issue by not using the results ShardSearchContextId but the original PIT ids context. Since only the target nodes change with PIT relocation and the context id remains fixed, this avoids running into the NPE issues. Closes #149371 * Revert "Fix Potential of NPE in PIT search after relocation (#149375)" This reverts commit 54b8a70. --------- Co-authored-by: Jonas Kunz <jonas.kunz@elastic.co> Co-authored-by: Christoph Büscher <christophbuescher@posteo.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After backporting #148983 to
9.3and9.4, the corresponding ES|QL capability became available on those versions too.This caused the test to attempt to execute in
9.3, which however doesn't haveCOUNTsupport on histograms and therefore fails:The fix is to just guard the test in addition on the required capability for
COUNTsupport with histogram types.