Create int bfloat16 vector formats #136627
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v9.3.0
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
benwtrent
reviewed
Oct 16, 2025
server/src/main/java/org/elasticsearch/index/codec/vectors/es93/ES93Int8FlatVectorFormat.java
Outdated
Show resolved
Hide resolved
thecoop
force-pushed
the
int-hnsw-bfloat16
branch
from
66172e3 to
1287a0b
Compare
benwtrent
reviewed
Oct 23, 2025
...r/src/main/java/org/elasticsearch/index/codec/vectors/ES814ScalarQuantizedVectorsFormat.java
Show resolved
Hide resolved
benwtrent
reviewed
Oct 23, 2025
Comment on lines
70
to
71
| return new Lucene104ScalarQuantizedVectorsWriter(state, encoding, rawVectorFormat.fieldsWriter(state), flatVectorScorer) { | ||
| }; |
There was a problem hiding this comment.
Suggested change
| return new Lucene104ScalarQuantizedVectorsWriter(state, encoding, rawVectorFormat.fieldsWriter(state), flatVectorScorer) { | |
| }; | |
| return new Lucene104ScalarQuantizedVectorsWriter(state, encoding, rawVectorFormat.fieldsWriter(state), flatVectorScorer); |
There was a problem hiding this comment.
The constructor is protected, so it needs to be called from a sneaky subclass. See apache/lucene#15357
This reverts commit 064392f.
|
I've removed the intermediate format, and pushed everything into the top-level formats |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create classes for quantized int vector formats that support bfloat16 and direct IO. This uses the new Lucene104 quantizer.