Tidy up Lucene104ScalarQuantizedVectorsWriter #15357
Conversation
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
thecoop
added
the
skip-changelog
| */ | ||
| protected Lucene104ScalarQuantizedVectorsWriter( | ||
| /** Sole constructor */ | ||
| public Lucene104ScalarQuantizedVectorsWriter( |
There was a problem hiding this comment.
seems OK, but why make it public?
There was a problem hiding this comment.
So the writer (and so the format it represents) can be created and used by other classes outside of Lucene104ScalarQuantizedVectorsFormat. The reader is already public.
There was a problem hiding this comment.
ok that is kind of a tautology - I will be like the 5-year-old here and ask so why do we want the writer to be created and used by other classes outside of Lucene104ScalarQuantizedVectorsFormat :) I really have no objection - just curious what motivated this
There was a problem hiding this comment.
See elastic/elasticsearch#136627 (comment) - we want to use the new quantizer in some updated formats in Elasticsearch
There was a problem hiding this comment.
got it thanks. Would love to see the bfloat16 support contributed here at some point!
2 participants
Fix up the javadocs and constructor accessibility