Skip to content

[DOCS] Fix docs preview workflow URL generation logic #129608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 18, 2025
Merged

[DOCS] Fix docs preview workflow URL generation logic #129608

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
104e10a
[DOCS] Update esql-lookup-join.md
leemthompo Apr 24, 2025
f2de6b7
Merge branch 'elastic:main' into main
leemthompo Apr 24, 2025
1ba7f47
Merge branch 'elastic:main' into main
leemthompo Apr 29, 2025
d38e1d8
Merge branch 'elastic:main' into main
leemthompo May 7, 2025
a273f2a
Merge branch 'elastic:main' into main
leemthompo May 21, 2025
fadb235
Merge branch 'elastic:main' into main
leemthompo May 26, 2025
60d0a4e
Merge branch 'elastic:main' into main
leemthompo Jun 18, 2025
2833047
Fix preview URLs path structure
leemthompo Jun 18, 2025
8997bc4
test change
leemthompo Jun 18, 2025
71a0494
remove test changes needs to be in follow up PR
leemthompo Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/docs-preview-comment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ jobs:
!/(^|\/)_snippets\//i.test(f.filename)
)
.map(f => {
let p = f.filename.replace(/\/index\.md$/i, '/');
if (p === f.filename) p = p.replace(/\.md$/i, '');
let p = f.filename.replace(/^docs\//, '').replace(/\/index\.md$/i, '/');
if (p === f.filename.replace(/^docs\//, '')) p = p.replace(/\.md$/i, '');
return `- [\`${f.filename}\`](${base}/${p})`;
});
if (!links.length) return; // nothing to do
Expand Down Expand Up @@ -68,4 +68,4 @@ jobs:
issue_number: prNum,
body
});
}
}