Skip to content

[DOCS] Fix docs preview workflow URL generation logic #129608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 18, 2025

Conversation

leemthompo
Copy link
Contributor

@leemthompo leemthompo commented Jun 18, 2025

corrects URL generation from workflow added in #129485

Updates the workflow to remove docs/ from generated preview paths

leemthompo and others added 9 commits April 24, 2025 09:58
- I trimmed the KEEP query in my final iteration in elastic#127215 but neglected to update the query itself, only the response. This fixes that so the query matches the response.

- 🚘 I also updated the table response to match other ESQL response tables
@leemthompo leemthompo self-assigned this Jun 18, 2025
@leemthompo leemthompo added >docs General docs changes Team:Docs Meta label for docs team labels Jun 18, 2025
Copy link
Contributor

🔍 Preview links for changed docs:

🔔 The preview site may take up to 3 minutes to finish building. These links will become live once it completes.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for this!

@leemthompo leemthompo changed the title [DOCS] Fix docs preview workflow to strip docs/ prefix from URLs [DOCS] Fix docs preview workflow URL generation logic Jun 18, 2025
@leemthompo leemthompo enabled auto-merge (squash) June 18, 2025 08:19
@leemthompo leemthompo merged commit f62fce9 into elastic:main Jun 18, 2025
27 checks passed
@leemthompo leemthompo deleted the test-docs-preview-fix branch June 18, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes Team:Docs Meta label for docs team v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants