Add support for the 'ISP' database to the geoip processor #108651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview: |
elasticsearchmachine
added
v8.15.0
needs:triage
masseyke
added
>enhancement
:Data Management/Ingest Node
|
Pinging @elastic/es-data-management (Team:Data Management) |
elasticsearchmachine
added
the
Team:Data Management
|
Hi @masseyke, I've created a changelog YAML for you. |
|
Hi @masseyke, I've updated the changelog YAML for you. Note that since this PR is labelled |
…elasticsearch into add-isp-geoip-database-support
joegallo
reviewed
May 14, 2024
joegallo
approved these changes
May 15, 2024
masseyke
added
the
auto-merge-without-approval
masseyke
removed
the
auto-merge-without-approval
This was referenced May 15, 2024
|
Related to #101080 |
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Jun 4, 2024
as well as elastic#108639 and elastic#108651 -- collapsing all these into a single highlight.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on to #107287, #107377, and #108639
Adds support for the 'GeoIP2 ISP' database from MaxMind to the geoip processor.
The geoip processor will automatically download the various 'GeoLite2' databases, but the 'GeoIP2 ISP' database is not a 'GeoLite2' database -- it's a commercial database available to those with a suitable license from MaxMind.
The support that is being added for it in this PR is in line with the support that we already have for MaxMind's 'GeoIP2 City' and 'GeoIP2 Country' databases -- that is, one would need to arrange their own download management via some custom endpoint or otherwise arrange for the relevant file(s) to be in the $ES_CONFIG/ingest-geoip directory on the nodes of the cluster.