-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the 'Domain' database to the geoip processor #108639
Add support for the 'Domain' database to the geoip processor #108639
Conversation
Documentation preview: |
Pinging @elastic/es-data-management (Team:Data Management) |
Hi @joegallo, I've created a changelog YAML for you. Note that since this PR is labelled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related to #101080 |
as well as elastic#108639 and elastic#108651 -- collapsing all these into a single highlight.
Follow on to #107287 and #107377
Adds support for the 'GeoIP2 Domain' database from MaxMind to the
geoip
processor.The
geoip
processor will automatically download the various 'GeoLite2' databases, but the 'GeoIP2 Domain' database is not a 'GeoLite2' database -- it's a commercial database available to those with a suitable license from MaxMind.The support that is being added for it in this PR is in line with the support that we already have for MaxMind's 'GeoIP2 City' and 'GeoIP2 Country' databases -- that is, one would need to arrange their own download management via some custom endpoint or otherwise arrange for the relevant file(s) to be in the
$ES_CONFIG/ingest-geoip
directory on the nodes of the cluster.