Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the 'Domain' database to the geoip processor #108639

Merged
merged 6 commits into from
May 14, 2024

Conversation

joegallo
Copy link
Contributor

Follow on to #107287 and #107377

Adds support for the 'GeoIP2 Domain' database from MaxMind to the geoip processor.

The geoip processor will automatically download the various 'GeoLite2' databases, but the 'GeoIP2 Domain' database is not a 'GeoLite2' database -- it's a commercial database available to those with a suitable license from MaxMind.

The support that is being added for it in this PR is in line with the support that we already have for MaxMind's 'GeoIP2 City' and 'GeoIP2 Country' databases -- that is, one would need to arrange their own download management via some custom endpoint or otherwise arrange for the relevant file(s) to be in the $ES_CONFIG/ingest-geoip directory on the nodes of the cluster.

@joegallo joegallo added >enhancement release highlight :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v8.15.0 labels May 14, 2024
@joegallo joegallo requested a review from masseyke May 14, 2024 20:07
Copy link
Contributor

Documentation preview:

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label May 14, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @joegallo, I've created a changelog YAML for you. Note that since this PR is labelled release highlight, you need to update the changelog YAML to fill out the extended information sections.

Copy link
Member

@masseyke masseyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joegallo joegallo merged commit cc6597d into elastic:main May 14, 2024
15 of 16 checks passed
@joegallo joegallo deleted the ingest-geoip-processor-domain branch May 14, 2024 21:49
@joegallo
Copy link
Contributor Author

Related to #101080

joegallo added a commit to joegallo/elasticsearch that referenced this pull request Jun 4, 2024
as well as elastic#108639 and elastic#108651 -- collapsing all these into a single
highlight.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >enhancement release highlight Team:Data Management Meta label for data/management team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants