Skip to content

Remove HLRC from ES codebase #105406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 12, 2024
Merged

Remove HLRC from ES codebase #105406

merged 3 commits into from
Feb 12, 2024

Conversation

joegallo
Copy link
Contributor

Closes #83423

#105294 and #105308 dropped the last java classes, so there's nothing left there anymore.

@joegallo
Drop the rest-high-level directory entirely
513d096
@joegallo
Drop references to the now-deleted hlrc
24960b3
@joegallo
Rely on :modules:aggregations directly
7d16c45 
rather than getting it as a transitive dependency from the now-deleted
rest-high-level client.
@joegallo joegallo requested a review from a team as a code owner February 12, 2024 15:35
@joegallo joegallo requested a review from masseyke February 12, 2024 15:35
@elasticsearchmachine elasticsearchmachine added Team:Clients Meta label for clients team and removed Team:Data Management Meta label for data/management team labels Feb 12, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/clients-team (Team:Clients)

mark-vieira
mark-vieira approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

masseyke
masseyke approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@masseyke masseyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few other files that still reference rest-high-level, so I'm not sure #83423 ought to be closed with this one, but this change looks good to me.

@joegallo joegallo mentioned this pull request Feb 12, 2024
Merged
@joegallo
Copy link
Contributor Author

#105409 for the docs changes.

@joegallo joegallo merged commit d543290 into elastic:main Feb 12, 2024
@joegallo joegallo deleted the drop-the-hlrc branch February 12, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masseyke masseyke masseyke approved these changes

@mark-vieira mark-vieira mark-vieira approved these changes

Assignees
No one assigned
Labels
>non-issue Team:Clients Meta label for clients team >tech debt v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove HLRC from ES codebase
4 participants
@joegallo @elasticsearchmachine @masseyke @mark-vieira