Move test-only search response x-content-parsing code to test codebase #105308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loads of code here that is only used in tests and one duplicate unused class that was only used as an indirection to parsing the `AsyncSearchResponse`. Moved what I could easily move via automated refactoring to `SearchResponseUtils` in tests and removed the duplicate now unused class from the client codebase.
original-brownbear
added
>non-issue
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
mark-vieira
approved these changes
Feb 8, 2024
|
Thanks both! |
|
Related to #83423 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly motivated by the wish to isolate where search responses are created in prod code as much as possible so that we can confidently clean up the remaining unpooled search response uses:
Loads of code here that is only used in tests and one duplicate unused class that was only used as an indirection to parsing the
AsyncSearchResponse. Moved what I could easily move via automated refactoring toSearchResponseUtilsin tests and removed the duplicate now unused class from the client codebase.