Skip to content

Release top-level response in TransportNodesAction #103845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DaveCTurner
Copy link
Contributor

Similarly to #103254, we should decRef the top-level response after
completing the listener too.

Similarly to elastic#103254, we should `decRef` the top-level response after
completing the listener too.
@DaveCTurner DaveCTurner added >non-issue :Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. v8.13.0 labels Jan 3, 2024
@DaveCTurner DaveCTurner requested a review from arteam January 3, 2024 09:08
@elasticsearchmachine elasticsearchmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Jan 3, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@DaveCTurner DaveCTurner requested a review from fcofdez January 3, 2024 09:08
Copy link
Contributor

@arteam arteam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@DaveCTurner DaveCTurner added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jan 3, 2024
@elasticsearchmachine elasticsearchmachine merged commit a9010f9 into elastic:main Jan 3, 2024
@DaveCTurner DaveCTurner deleted the 2024/01/03/TransportNodesAction-refcount-response branch January 3, 2024 11:03
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Jan 3, 2024
@DaveCTurner DaveCTurner restored the 2024/01/03/TransportNodesAction-refcount-response branch June 17, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. >non-issue Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants