Refcount responses in TransportNodesAction
#103254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we `decRef()` the per-node responses just after adding them to the `responses` collection, but in fact we should keep them alive until we've constructed the final response. This commit does that.
DaveCTurner
added
>non-issue
:Distributed Indexing/Distributed
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
This comment was marked as resolved.
This comment was marked as resolved.
DaveCTurner
commented
Dec 12, 2023
| addReleaseOnCancellationListener(); | ||
| } | ||
|
|
||
| private void addReleaseOnCancellationListener() { |
There was a problem hiding this comment.
Incredibly if you write this inline in the anonymous constructor then the compiler blows up with a NPE: https://gradle-enterprise.elastic.co/s/pp3aym5qktpa2
arteam
approved these changes
Jan 2, 2024
| cancellableTask.addListener(() -> { | ||
| final List<NodeResponse> drainedResponses; | ||
| synchronized (responses) { | ||
| drainedResponses = List.copyOf(responses); |
There was a problem hiding this comment.
I was wondering if could add copy and remove elements in one iteration:
var iterator = responses.iterator();
while (iterator.hasNext()) {
drainedResponses.add(iterator.next());
iterator.remove();
}
There was a problem hiding this comment.
You can, but adding elements one-by-one to a list potentially involves more allocations to grow the list incrementally, and removing items from a list iterator one-by-one is an O(N²) operation.
|
|
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jan 3, 2024
Similarly to elastic#103254, we should `decRef` the top-level response after completing the listener too.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 3, 2024
Similarly to #103254, we should `decRef` the top-level response after completing the listener too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we
decRef()the per-node responses just after adding them to theresponsescollection, but in fact we should keep them alive untilwe've constructed the final response. This commit does that.