Skip to content

Add rank_feature, rank_feature fields and rank_feature query #3941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 15, 2019
Merged

Add rank_feature, rank_feature fields and rank_feature query #3941

merged 6 commits into from
Jul 15, 2019

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Jul 10, 2019

This PR provides support for

Closes #3938

Mpdreamz
Mpdreamz approved these changes Jul 11, 2019
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome these have eluded us for a while now.

QueryDslUsageTestsBase really needs to inherit from ApiIntegrationTestBase sooner rather than later.

russcam added 5 commits July 12, 2019 19:52
@russcam
Implement rank_feature property
cf082c0 
This commit implements the rank_feature property, which can be used with the rank_feature query
@russcam
Implement rank_features property
85122a3 
This commit implements the rank_features property, which can be used with the rank_feature query
@russcam
Add rank_feature query
d5badde 
This commit adds the rank feature query to the query DSL.

Closes #3938
@russcam
fix FieldCapabilities integration test
954144a
@russcam
Add rank_feature and rank_features to visitors/mappers
b95ba3c
@russcam russcam merged commit 453a608 into master Jul 15, 2019
russcam added a commit that referenced this pull request Jul 15, 2019
@russcam
Add rank_feature, rank_feature fields and rank_feature query (#3941)
306b13f 
This commit adds the rank_feature, rank_feature fields and rank_feature query

* Add rank_feature property
* Add rank_features property
* Add rank_feature query
* fix FieldCapabilities integration test

Closes #3938

(cherry picked from commit 453a608)
russcam added a commit that referenced this pull request Jul 18, 2019
@russcam
Add rank_feature, rank_feature fields and rank_feature query (#3941)
a7313e4 
This commit adds the rank_feature, rank_feature fields and rank_feature query

* Add rank_feature property
* Add rank_features property
* Add rank_feature query
* fix FieldCapabilities integration test

Closes #3938

(cherry picked from commit 453a608)
codebrain pushed a commit that referenced this pull request Jul 19, 2019
@russcam
Add rank_feature, rank_feature fields and rank_feature query (#3941)
626d2d8 
This commit adds the rank_feature, rank_feature fields and rank_feature query

* Add rank_feature property
* Add rank_features property
* Add rank_feature query
* fix FieldCapabilities integration test

Closes #3938

(cherry picked from commit 453a608)
@russcam russcam deleted the feature/3938 branch July 24, 2019 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add rank_feature, rank_features field datatypes and rank_feature query
2 participants
@russcam @Mpdreamz