Skip to content

Commit 6a21756

Browse files
committed
Add rank_feature and rank_features to visitors/mappers
1 parent 1bfe848 commit 6a21756

File tree

5 files changed

+39
-0
lines changed

5 files changed

+39
-0
lines changed

src/Nest/Mapping/Visitor/IMappingVisitor.cs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,10 @@ public interface IMappingVisitor
4949
void Visit(IIpRangeProperty property);
5050

5151
void Visit(IJoinProperty property);
52+
53+
void Visit(IRankFeatureProperty property);
54+
55+
void Visit(IRankFeaturesProperty property);
5256
}
5357

5458
public class NoopMappingVisitor : IMappingVisitor
@@ -100,5 +104,9 @@ public virtual void Visit(IDateRangeProperty property) { }
100104
public virtual void Visit(IIpRangeProperty property) { }
101105

102106
public virtual void Visit(IJoinProperty property) { }
107+
108+
public virtual void Visit(IRankFeatureProperty property) { }
109+
110+
public virtual void Visit(IRankFeaturesProperty property) { }
103111
}
104112
}

src/Nest/Mapping/Visitor/IPropertyVisitor.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,10 @@ public interface IPropertyVisitor
4848

4949
void Visit(IJoinProperty type, PropertyInfo propertyInfo, ElasticsearchPropertyAttributeBase attribute);
5050

51+
void Visit(IRankFeatureProperty type, PropertyInfo propertyInfo, ElasticsearchPropertyAttributeBase attribute);
52+
53+
void Visit(IRankFeaturesProperty type, PropertyInfo propertyInfo, ElasticsearchPropertyAttributeBase attribute);
54+
5155
void Visit(IProperty type, PropertyInfo propertyInfo, ElasticsearchPropertyAttributeBase attribute);
5256

5357
IProperty Visit(PropertyInfo propertyInfo, ElasticsearchPropertyAttributeBase attribute);

src/Nest/Mapping/Visitor/MappingWalker.cs

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,18 @@ public void Accept(IProperties properties)
211211
case FieldType.Join:
212212
Visit<IJoinProperty>(field, t => { _visitor.Visit(t); });
213213
break;
214+
case FieldType.RankFeature:
215+
Visit<IRankFeatureProperty>(field, t =>
216+
{
217+
_visitor.Visit(t);
218+
});
219+
break;
220+
case FieldType.RankFeatures:
221+
Visit<IRankFeaturesProperty>(field, t =>
222+
{
223+
_visitor.Visit(t);
224+
});
225+
break;
214226
}
215227
}
216228
}

src/Nest/Mapping/Visitor/NoopPropertyVisitor.cs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,10 @@ public void Visit(IIpRangeProperty type, PropertyInfo propertyInfo, Elasticsearc
3636

3737
public void Visit(IJoinProperty type, PropertyInfo propertyInfo, ElasticsearchPropertyAttributeBase attribute) { }
3838

39+
public virtual void Visit(IRankFeatureProperty type, PropertyInfo propertyInfo, ElasticsearchPropertyAttributeBase attribute) { }
40+
41+
public virtual void Visit(IRankFeaturesProperty type, PropertyInfo propertyInfo, ElasticsearchPropertyAttributeBase attribute) { }
42+
3943
public virtual void Visit(IIpProperty type, PropertyInfo propertyInfo, ElasticsearchPropertyAttributeBase attribute) { }
4044

4145
public virtual void Visit(IGeoPointProperty type, PropertyInfo propertyInfo, ElasticsearchPropertyAttributeBase attribute) { }
@@ -122,6 +126,12 @@ public void Visit(IProperty type, PropertyInfo propertyInfo, ElasticsearchProper
122126
case IIpRangeProperty ipRangeType:
123127
Visit(ipRangeType, propertyInfo, attribute);
124128
break;
129+
case IRankFeatureProperty rankFeature:
130+
Visit(rankFeature, propertyInfo, attribute);
131+
break;
132+
case IRankFeaturesProperty rankFeatures:
133+
Visit(rankFeatures, propertyInfo, attribute);
134+
break;
125135
}
126136
}
127137
}

src/Tests/Tests/Indices/MappingManagement/GetMapping/GetMappingApiTest.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ private static void AssertVisitedProperties(GetMappingResponse response)
102102
visitor.CountsShouldContainKeyAndCountBe("long_range", 1);
103103
visitor.CountsShouldContainKeyAndCountBe("ip_range", 1);
104104
visitor.CountsShouldContainKeyAndCountBe("nested", 1);
105+
visitor.CountsShouldContainKeyAndCountBe("rank_feature", 1);
105106
}
106107
}
107108

@@ -191,6 +192,10 @@ internal class TestVisitor : IMappingVisitor
191192

192193
public void Visit(ITypeMapping mapping) => Increment("type");
193194

195+
public void Visit(IRankFeatureProperty mapping) => Increment("rank_feature");
196+
197+
public void Visit(IRankFeaturesProperty mapping) => Increment("rank_features");
198+
194199
private void Increment(string key)
195200
{
196201
if (!Counts.ContainsKey(key)) Counts.Add(key, 0);

0 commit comments

Comments
 (0)