Skip to content

Convert rollover lifecycle action to accept max size as a string and not long? #3775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 29, 2019
Merged

Convert rollover lifecycle action to accept max size as a string and not long? #3775

merged 2 commits into from
May 29, 2019

Conversation

codebrain
Copy link
Contributor

Convert rollover lifecycle action to accept max size as a string instead of long?

Breaking change from 6.7 to 6.8

Fixes #3768

@codebrain
Copy link
Contributor Author

A non-breaking way to fix this would be to implement a custom converter and always append the "b" suffix to the end of the byte value.

Thoughts @Mpdreamz @russcam ?

@codebrain
Copy link
Contributor Author

Will implement MaximumSizeAsString and use that instead, patching the long? value setter and getter with b suffix.

@codebrain codebrain self-assigned this May 28, 2019
@codebrain codebrain merged commit 7555706 into 6.x May 29, 2019
codebrain added a commit that referenced this pull request May 30, 2019
@codebrain
Convert rollover lifecycle action to accept max size as a string and …
117d3b6 
…not long? #3775
@codebrain
Copy link
Contributor Author

Ported to 7.x

@Mpdreamz Mpdreamz deleted the fix/ilm-rolloveraction branch June 17, 2019 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@codebrain codebrain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@codebrain