Convert rollover lifecycle action to accept max size as a string and not long? #3775

Author: codebrain

src/Nest/XPack/Ilm/Actions/RolloverAction.cs

@@ -23,10 +23,10 @@ public interface IRolloverLifecycleAction : ILifecycleAction
 		long? MaximumDocuments { get; set; }
 
 		/// <summary>
-		/// Max primary shard index storage size in bytes.
+		/// Max primary shard index storage size using byte notation (e.g. $0gb, 100mb...)
 		/// </summary>
 		[DataMember(Name = "max_size")]
-		long? MaximumSize { get; set; }
+		string MaximumSize { get; set; }
 	}
 
 	public class RolloverLifecycleAction : IRolloverLifecycleAction
@@ -38,7 +38,7 @@ public class RolloverLifecycleAction : IRolloverLifecycleAction
 		public long? MaximumDocuments { get; set; }
 
 		/// <inheritdoc />
-		public long? MaximumSize { get; set; }
+		public string MaximumSize { get; set; }
 	}
 
 	public class RolloverLifecycleActionDescriptor
@@ -51,10 +51,10 @@ public class RolloverLifecycleActionDescriptor
 		long? IRolloverLifecycleAction.MaximumDocuments { get; set; }
 
 		/// <inheritdoc cref="IRolloverLifecycleAction.MaximumSize" />
-		long? IRolloverLifecycleAction.MaximumSize { get; set; }
+		string IRolloverLifecycleAction.MaximumSize { get; set; }
 
 		/// <inheritdoc cref="IRolloverLifecycleAction.MaximumSize" />
-		public RolloverLifecycleActionDescriptor MaximumSize(long? maximumSize) => Assign(maximumSize, (a, v) => a.MaximumSize = maximumSize);
+		public RolloverLifecycleActionDescriptor MaximumSize(string maximumSize) => Assign(maximumSize, (a, v) => a.MaximumSize = maximumSize);
 
 		/// <inheritdoc cref="IRolloverLifecycleAction.MaximumAge" />
 		public RolloverLifecycleActionDescriptor MaximumAge(Time maximumAge) => Assign(maximumAge, (a, v) => a.MaximumAge = maximumAge);