Skip to content

obsolete copy_settings as of 6.4 it will no longer allow false and wi… #3416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2018
Merged

obsolete copy_settings as of 6.4 it will no longer allow false and wi… #3416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/CodeGeneration/ApiGenerator/Overrides/GlobalOverrides.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ public class GlobalOverrides : EndpointOverridesBase
public override IDictionary<string, string> ObsoleteQueryStringParams { get; set; } = new Dictionary<string, string>
{
{ "parent", "the parent parameter has been deprecated from elasticsearch, please use routing instead directly."},
{ "update_all_types", "Elasticsearch 6.x only allows a single type per index so this parameter is now useless"}
{ "update_all_types", "Elasticsearch 6.x only allows a single type per index so this parameter is now useless"},
{ "copy_settings", "Elasticsearch 6.4 will throw an exception if this is turned off see elastic/elasticsearch#30404"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having the link to the commit was useful to understand the behaviour. Do we want to surface it in the Obsolete message though (too much information)?

};

public override IEnumerable<string> SkipQueryStringParams { get; } = new[]
Expand Down
2 changes: 2 additions & 0 deletions src/Elasticsearch.Net/Domain/RequestParameters/RequestParameters.Generated.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1434,6 +1434,7 @@ public partial class ShrinkIndexRequestParameters : RequestParameters<ShrinkInde
{
public override HttpMethod DefaultHttpMethod => HttpMethod.PUT;
///<summary>whether or not to copy settings from the source index (defaults to false)</summary>
[Obsolete("Scheduled to be removed in 7.0, Elasticsearch 6.4 will throw an exception if this is turned off see elastic/elasticsearch#30404")]
public bool? CopySettings { get => Q<bool?>("copy_settings"); set => Q("copy_settings", value); }
///<summary>Explicit operation timeout</summary>
public TimeSpan Timeout { get => Q<TimeSpan>("timeout"); set => Q("timeout", value); }
Expand All @@ -1447,6 +1448,7 @@ public partial class SplitIndexRequestParameters : RequestParameters<SplitIndexR
{
public override HttpMethod DefaultHttpMethod => HttpMethod.PUT;
///<summary>whether or not to copy settings from the source index (defaults to false)</summary>
[Obsolete("Scheduled to be removed in 7.0, Elasticsearch 6.4 will throw an exception if this is turned off see elastic/elasticsearch#30404")]
public bool? CopySettings { get => Q<bool?>("copy_settings"); set => Q("copy_settings", value); }
///<summary>Explicit operation timeout</summary>
public TimeSpan Timeout { get => Q<TimeSpan>("timeout"); set => Q("timeout", value); }
Expand Down
2 changes: 2 additions & 0 deletions src/Nest/_Generated/_Descriptors.generated.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2513,6 +2513,7 @@ public ShrinkIndexDescriptor(IndexName index, IndexName target) : base(r=>r.Requ
// Request parameters

///<summary>whether or not to copy settings from the source index (defaults to false)</summary>
[Obsolete("Scheduled to be removed in 7.0, Elasticsearch 6.4 will throw an exception if this is turned off see elastic/elasticsearch#30404")]
public ShrinkIndexDescriptor CopySettings(bool? copySettings = true) => Qs("copy_settings", copySettings);
///<summary>Explicit operation timeout</summary>
public ShrinkIndexDescriptor Timeout(Time timeout) => Qs("timeout", timeout);
Expand Down Expand Up @@ -2541,6 +2542,7 @@ public SplitIndexDescriptor(IndexName index, IndexName target) : base(r=>r.Requi
// Request parameters

///<summary>whether or not to copy settings from the source index (defaults to false)</summary>
[Obsolete("Scheduled to be removed in 7.0, Elasticsearch 6.4 will throw an exception if this is turned off see elastic/elasticsearch#30404")]
public SplitIndexDescriptor CopySettings(bool? copySettings = true) => Qs("copy_settings", copySettings);
///<summary>Explicit operation timeout</summary>
public SplitIndexDescriptor Timeout(Time timeout) => Qs("timeout", timeout);
Expand Down
2 changes: 2 additions & 0 deletions src/Nest/_Generated/_Requests.generated.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4931,6 +4931,7 @@ public ShrinkIndexRequest(IndexName index, IndexName target) : base(r=>r.Require

// Request parameters
///<summary>whether or not to copy settings from the source index (defaults to false)</summary>
[Obsolete("Scheduled to be removed in 7.0, Elasticsearch 6.4 will throw an exception if this is turned off see elastic/elasticsearch#30404")]
public bool? CopySettings { get => Q<bool?>("copy_settings"); set => Q("copy_settings", value); }
///<summary>Explicit operation timeout</summary>
public Time Timeout { get => Q<Time>("timeout"); set => Q("timeout", value); }
Expand Down Expand Up @@ -5235,6 +5236,7 @@ public SplitIndexRequest(IndexName index, IndexName target) : base(r=>r.Required

// Request parameters
///<summary>whether or not to copy settings from the source index (defaults to false)</summary>
[Obsolete("Scheduled to be removed in 7.0, Elasticsearch 6.4 will throw an exception if this is turned off see elastic/elasticsearch#30404")]
public bool? CopySettings { get => Q<bool?>("copy_settings"); set => Q("copy_settings", value); }
///<summary>Explicit operation timeout</summary>
public Time Timeout { get => Q<Time>("timeout"); set => Q("timeout", value); }
Expand Down