obsolete copy_settings as of 6.4 it will no longer allow false and wi… #3416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll be removed on the server in 8.x and in the client in 7.x
russcam
approved these changes
Oct 5, 2018
| @@ -35,7 +35,8 @@ public class GlobalOverrides : EndpointOverridesBase | |||
| public override IDictionary<string, string> ObsoleteQueryStringParams { get; set; } = new Dictionary<string, string> | |||
| { | |||
| { "parent", "the parent parameter has been deprecated from elasticsearch, please use routing instead directly."}, | |||
| { "update_all_types", "Elasticsearch 6.x only allows a single type per index so this parameter is now useless"} | |||
| { "update_all_types", "Elasticsearch 6.x only allows a single type per index so this parameter is now useless"}, | |||
| { "copy_settings", "Elasticsearch 6.4 will throw an exception if this is turned off see elastic/elasticsearch#30404"} | |||
There was a problem hiding this comment.
Having the link to the commit was useful to understand the behaviour. Do we want to surface it in the Obsolete message though (too much information)?
russcam
pushed a commit
that referenced
this pull request
Oct 26, 2018
It will no longer allow false and will be removed on the server in 8.x, and in the client in 7.x (cherry picked from commit 559367b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ll be removed on the server in 8.x and in the client in 7.x