Skip to content

Closes #3251. Rename levenstein to levenshtein. #3264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2018
Merged

Closes #3251. Rename levenstein to levenshtein. #3264

merged 1 commit into from
May 31, 2018

Conversation

codebrain
Copy link
Contributor

Unsure if we should rename the enumeration value at this stage as it would break binary compatibility.

Potentially consider implementing another enumeration value with the correct spelling? @russcam - thoughts?

Mpdreamz
Mpdreamz requested changes May 30, 2018
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to renaming the enum in master and adding it as an additional enum value in the backport while obsoleting the misspelled variant.

@codebrain codebrain merged commit a7ede8c into master May 31, 2018
@codebrain codebrain deleted the feature/levenshtein branch May 31, 2018 06:08
@codebrain
Copy link
Contributor Author

Ported to 6.x

@russcam
Copy link
Contributor

russcam commented May 31, 2018

@codebrain this can't be backported to 6.x because e.g. Elasticsearch 6.0 uses levenstein

https://github.com/elastic/elasticsearch/blob/6002b41b5f8d6ccfc5b5569ee00958ca565bb7d2/core/src/main/java/org/elasticsearch/search/suggest/term/TermSuggestionBuilder.java#L586

@Mpdreamz
Copy link
Member

Think this was merged to soon, should still rename the enum in master IMO.

@russcam russcam mentioned this pull request Jun 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebrain @russcam @Mpdreamz