Skip to content

Rename jarowinkler to jaro_winkler. #3263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 31, 2018
Merged

Rename jarowinkler to jaro_winkler. #3263

merged 2 commits into from
May 31, 2018

Conversation

codebrain
Copy link
Contributor

@codebrain codebrain merged commit d097a6f into master May 31, 2018
@codebrain codebrain deleted the feature/jaro-winkler branch May 31, 2018 06:31
@codebrain
Copy link
Contributor Author

Ported to 6.x

@russcam
Copy link
Contributor

russcam commented Jun 1, 2018

Similarly to #3264, this should not be ported to 6.x directly in 1f7e5ec as e.g. Elasticsearch 6.0 supports only jarowinkler:

https://github.com/elastic/elasticsearch/blob/6002b41b5f8d6ccfc5b5569ee00958ca565bb7d2/core/src/main/java/org/elasticsearch/search/suggest/term/TermSuggestionBuilder.java#L590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebrain @russcam @Mpdreamz