Adding support for the date_nanos field type #1803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaiera
reviewed
Nov 11, 2021
You're right -- the parser only produces milliseconds, and we're only grabbing milliseconds from it at https://github.com/masseyke/elasticsearch-hadoop/blob/feature/date-nanos/spark/core/src/main/scala/org/elasticsearch/spark/serialization/ScalaValueReader.scala#L181. |
|
OK, I've changed it so that for date_nanos fields we keep track of the nanoseconds the whole way through. In addition to the unit tests, I manually pulled data out of an index in spark shell and wrote it out to a new index, and the nanoseconds were still correctly there. |
masseyke
added a commit
to masseyke/elasticsearch-hadoop
that referenced
this pull request
Dec 20, 2021
Adding support for the date_nanos field type. This field type is now treated in the same way as the date field type, except that we keep track of nanoseconds. Closes elastic#1653
masseyke
added a commit
that referenced
this pull request
Dec 20, 2021
masseyke
added a commit
to masseyke/elasticsearch-hadoop
that referenced
this pull request
Dec 20, 2021
Adding support for the date_nanos field type. This field type is now treated in the same way as the date field type, except that we keep track of nanoseconds. Closes elastic#1653
masseyke
added a commit
that referenced
this pull request
Dec 20, 2021
masseyke
added a commit
that referenced
this pull request
Dec 21, 2021
masseyke
added a commit
that referenced
this pull request
Dec 21, 2021
masseyke
added a commit
that referenced
this pull request
Apr 7, 2022
In #1803 we added support for the data_nanos Elasticsearch field type. However there is a bug in that sets the zone offset to the offset right now, as opposed to what the zone offset was at the time of the date. So for example if the date was 2015-01-01T06:10:30.123456789-06:00, then if you read that date after daylight saving had begun you would see it as 2015-01-01T06:10:30.123456789-05:00.
masseyke
added a commit
to masseyke/elasticsearch-hadoop
that referenced
this pull request
Apr 7, 2022
In elastic#1803 we added support for the data_nanos Elasticsearch field type. However there is a bug in that sets the zone offset to the offset right now, as opposed to what the zone offset was at the time of the date. So for example if the date was 2015-01-01T06:10:30.123456789-06:00, then if you read that date after daylight saving had begun you would see it as 2015-01-01T06:10:30.123456789-05:00.
masseyke
added a commit
to masseyke/elasticsearch-hadoop
that referenced
this pull request
Apr 7, 2022
In elastic#1803 we added support for the data_nanos Elasticsearch field type. However there is a bug in that sets the zone offset to the offset right now, as opposed to what the zone offset was at the time of the date. So for example if the date was 2015-01-01T06:10:30.123456789-06:00, then if you read that date after daylight saving had begun you would see it as 2015-01-01T06:10:30.123456789-05:00.
This was referenced Apr 7, 2022
masseyke
added a commit
that referenced
this pull request
Apr 8, 2022
In #1803 we added support for the data_nanos Elasticsearch field type. However there is a bug in that sets the zone offset to the offset right now, as opposed to what the zone offset was at the time of the date. So for example if the date was 2015-01-01T06:10:30.123456789-06:00, then if you read that date after daylight saving had begun you would see it as 2015-01-01T06:10:30.123456789-05:00.
masseyke
added a commit
that referenced
this pull request
Apr 8, 2022
In #1803 we added support for the data_nanos Elasticsearch field type. However there is a bug in that sets the zone offset to the offset right now, as opposed to what the zone offset was at the time of the date. So for example if the date was 2015-01-01T06:10:30.123456789-06:00, then if you read that date after daylight saving had begun you would see it as 2015-01-01T06:10:30.123456789-05:00.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for the date_nanos field type. This field type is now treated in the same way as the date field type.
Closes #1653