-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vector search example #1778
Merged
Merged
Vector search example #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelgrinberg
force-pushed
the
vector-example
branch
from
April 12, 2024 18:29
c1a21b6
to
4cda418
Compare
pquentin
reviewed
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks!
miguelgrinberg
commented
Apr 16, 2024
pquentin
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM. Just need to skip on 8.0.
github-actions bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
* Vector search example * addressed feedback * vectors example tests * skip vectors integration test for stacks < 8.11 --------- Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co> (cherry picked from commit b5800d4)
miguelgrinberg
added a commit
that referenced
this pull request
Apr 29, 2024
* Vector search example * addressed feedback * vectors example tests * skip vectors integration test for stacks < 8.11 --------- Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co> (cherry picked from commit b5800d4)
miguelgrinberg
added a commit
that referenced
this pull request
Apr 29, 2024
* Vector search example * addressed feedback * vectors example tests * skip vectors integration test for stacks < 8.11 --------- Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co> (cherry picked from commit b5800d4) Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1776 and #1777.