Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector search example #1778

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Conversation

miguelgrinberg
Copy link
Collaborator

Depends on #1776 and #1777.

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

examples/async/vectors.py Outdated Show resolved Hide resolved
examples/async/vectors.py Outdated Show resolved Hide resolved
examples/async/vectors.py Outdated Show resolved Hide resolved
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. Just need to skip on 8.0.

examples/async/vectors.py Outdated Show resolved Hide resolved
@miguelgrinberg miguelgrinberg merged commit b5800d4 into elastic:main Apr 18, 2024
15 checks passed
@miguelgrinberg miguelgrinberg deleted the vector-example branch April 18, 2024 13:30
@miguelgrinberg miguelgrinberg added the backport 8.x Backport to 8.x label Apr 29, 2024
github-actions bot pushed a commit that referenced this pull request Apr 29, 2024
* Vector search example

* addressed feedback

* vectors example tests

* skip vectors integration test for stacks < 8.11

---------

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
(cherry picked from commit b5800d4)
miguelgrinberg added a commit that referenced this pull request Apr 29, 2024
* Vector search example

* addressed feedback

* vectors example tests

* skip vectors integration test for stacks < 8.11

---------

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
(cherry picked from commit b5800d4)
miguelgrinberg added a commit that referenced this pull request Apr 29, 2024
* Vector search example

* addressed feedback

* vectors example tests

* skip vectors integration test for stacks < 8.11

---------

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
(cherry picked from commit b5800d4)

Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 8.x Backport to 8.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants