fix(6107): skipping escaping secrets in policy test because it is flaky #6120
Conversation
kaanyalti
force-pushed
the
fix-6107/skip-excaping-secret-test
branch
from
1159334 to
4abe6b9
Compare
|
This pull request does not have a backport label. Could you fix it @kaanyalti? 🙏
|
|
|
mergify
bot
added
the
backport-8.x
kaanyalti
force-pushed
the
fix-6107/skip-excaping-secret-test
branch
from
4abe6b9 to
ff441c8
Compare
kaanyalti
force-pushed
the
fix-6107/skip-excaping-secret-test
branch
from
ff441c8 to
cfd732f
Compare
Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
| @@ -30,6 +30,7 @@ func TestEscapingSecretsInPolicy(t *testing.T) { | |||
| Stack: &define.Stack{}, | |||
| Sudo: true, | |||
| }) | |||
| t.Skip("flaky test: https://github.com/elastic/elastic-agent/issues/6107") | |||
There was a problem hiding this comment.
Can you move this line as the first line in the test? Thanks.
There was a problem hiding this comment.
Linting starts complaining, is there a way to turn linting off for that block of code? something like //skip-linting-here
There was a problem hiding this comment.
There's the nolint tag, but don't know which one corresponds to this one
There was a problem hiding this comment.
What does it complain about?
There was a problem hiding this comment.
@swiatekm our linter enforces that the setup of the test define.Require is always the first line in a test. t.Skip should go after.
|
pierrehilbert
added
the
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
…ky (#6120) * fix(6107): skipping escaping secrets in policy test because it is flaky * fix(6107): fix linting * Update testing/integration/escaping_secrets_in_policy_test.go Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> (cherry picked from commit e983650)
…ky (#6120) * fix(6107): skipping escaping secrets in policy test because it is flaky * fix(6107): fix linting * Update testing/integration/escaping_secrets_in_policy_test.go Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> (cherry picked from commit e983650)
|
Backporting this PR to |
…ky (#6120) * fix(6107): skipping escaping secrets in policy test because it is flaky * fix(6107): fix linting * Update testing/integration/escaping_secrets_in_policy_test.go Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> (cherry picked from commit e983650)
…ky (#6120) (#6127) * fix(6107): skipping escaping secrets in policy test because it is flaky * fix(6107): fix linting * Update testing/integration/escaping_secrets_in_policy_test.go Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> (cherry picked from commit e983650) Co-authored-by: Kaan Yalti <kaan.yalti@elastic.co>
…ky (#6120) (#6131) * fix(6107): skipping escaping secrets in policy test because it is flaky * fix(6107): fix linting * Update testing/integration/escaping_secrets_in_policy_test.go Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> --------- Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> (cherry picked from commit e983650) Co-authored-by: Kaan Yalti <kaan.yalti@elastic.co>
What does this PR do?
Skips test that was added in #5987
Why is it important?
The test is flaky, will skip until it is fixed
Checklist
[ ] My code follows the style guidelines of this project[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testRelated issues