Enhancement/5320 add integration test escape secrets in policy #5987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @kaanyalti? 🙏
|
|
|
mergify
bot
added
the
backport-8.x
pierrehilbert
added
the
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
rdner
reviewed
Nov 11, 2024
changelog/fragments/1731292950-added-integration-tests-for-escaping-secrets-in-policy.yaml
Outdated
Show resolved
Hide resolved
kaanyalti
force-pushed
the
enhancement/5320_add_integration_test_escape_secrets_in_policy
branch
from
8435e50 to
bcaad75
Compare
kaanyalti
force-pushed
the
enhancement/5320_add_integration_test_escape_secrets_in_policy
branch
from
c332c26 to
cb9abce
Compare
|
blakerouse
approved these changes
Nov 13, 2024
rdner
approved these changes
Nov 13, 2024
swiatekm
approved these changes
Nov 14, 2024
mergify bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
* enhancement(5320): added integration test and package policy template * enhancement(5320): updated struct * enhancement(5320): added test case where we get install package and get diagnostics * enhancement(5320): updated tests removed template file * enhancement(5320): updated tests, fixed error in parsing pre-config * enhancement(5320): added changelog * enhancement(5320): ran mage addLicenseHeaders * ehancement(5320): update import order * enhancement(5320): added force flag to package installation * enhancement(5320): remove duplicate force flag * enhancement(5320): remove changelog * enhancement(5320): updated test case, corrected assertion (cherry picked from commit e6f7de4)
5 tasks
kaanyalti
added a commit
that referenced
this pull request
Nov 18, 2024
#6029) * enhancement(5320): added integration test and package policy template * enhancement(5320): updated struct * enhancement(5320): added test case where we get install package and get diagnostics * enhancement(5320): updated tests removed template file * enhancement(5320): updated tests, fixed error in parsing pre-config * enhancement(5320): added changelog * enhancement(5320): ran mage addLicenseHeaders * ehancement(5320): update import order * enhancement(5320): added force flag to package installation * enhancement(5320): remove duplicate force flag * enhancement(5320): remove changelog * enhancement(5320): updated test case, corrected assertion (cherry picked from commit e6f7de4) Co-authored-by: Kaan Yalti <kaan.yalti@elastic.co> Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
blakerouse
pushed a commit
to blakerouse/elastic-agent
that referenced
this pull request
Nov 18, 2024
…ic#5987) * enhancement(5320): added integration test and package policy template * enhancement(5320): updated struct * enhancement(5320): added test case where we get install package and get diagnostics * enhancement(5320): updated tests removed template file * enhancement(5320): updated tests, fixed error in parsing pre-config * enhancement(5320): added changelog * enhancement(5320): ran mage addLicenseHeaders * ehancement(5320): update import order * enhancement(5320): added force flag to package installation * enhancement(5320): remove duplicate force flag * enhancement(5320): remove changelog * enhancement(5320): updated test case, corrected assertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds integration test for testing escaping secrets in the agent config. This test case replicates the steps outlined in the following issue.
Why is it important?
We currently don't have integration tests covering this use case
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files./changelog/fragmentsusing the changelog toolHow to test this PR locally
Run
GOTEST_FLAGS='-test.run ^TestEscapingSecretsInPolicy$' mage integration:testfor the platforms and packages that you wantRelated issues