Skip to content

Add a link to the Node.js ECS logging tutorial in the Cloud docs #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

kilfoyle
Copy link
Contributor

This adds a link to a new Node.JS ECS logging tutorial in the Cloud docs.

@bmorelli25, or anyone, please let me know if you think there might be a better place for this link.

@apmmachine
Copy link
Contributor

apmmachine commented Sep 10, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-10T20:06:34.133+0000

  • Duration: 8 min 50 sec

  • Commit: 9072de3

Trends 🧪

Image of Build Times

@bmorelli25
Copy link
Member

Jenkins, run the tests please

@bmorelli25
Copy link
Member

@elasticmachine, run elasticsearch-ci/docs

@kilfoyle kilfoyle changed the title Update intro.asciidoc Add a link to the Python ECS logging tutorial in the Cloud docs Sep 10, 2021
@kilfoyle kilfoyle changed the title Add a link to the Python ECS logging tutorial in the Cloud docs Add a link to the Node.js ECS logging tutorial in the Cloud docs Sep 10, 2021
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🦖

@trentm
Copy link
Member

trentm commented Sep 10, 2021

Nice. It might also be nice to add a link to the bottom of the Winston setup section here: https://www.elastic.co/guide/en/ecs-logging/nodejs/master/winston.html#_setup_3 (repo file: https://github.com/elastic/ecs-logging-nodejs/blob/master/docs/winston.asciidoc), if you like.

@kilfoyle
Copy link
Contributor Author

Thanks @trentm! I'm not sure how to add another file to this PR so I just opened another PR for the winston logging page:
#100

@trentm
Copy link
Member

trentm commented Sep 10, 2021

@elasticmachine, run elasticsearch-ci/docs

@bmorelli25 I this hooked up for this repo? I don't see a GH check that results from that request.

@bmorelli25
Copy link
Member

It should be. The check was added in https://github.com/elastic/infra/pull/26395.

@bmorelli25
Copy link
Member

@elasticmachine, run elasticsearch-ci/docs

@bmorelli25
Copy link
Member

The webhook to trigger the build also exists already... 🤔

@bmorelli25
Copy link
Member

I must've missed something, somewhere... @gtback, do you see an obvious reason why docs ci won't run in this repo?

@trentm
Copy link
Member

trentm commented Sep 13, 2021

@bmorelli25 @gtback Possibly broken by the repo re-naming from "ecs-logging-js" to "ecs-logging-nodejs"?

Nope: That PR used the "...-nodejs" repo name.

@gtback
Copy link
Member

gtback commented Sep 13, 2021

I must've missed something, somewhere... @gtback, do you see an obvious reason why docs ci won't run in this repo?

The jobs are running, but aren't able to report the status back; there are a bunch of jobs here for this PR.

I believe the issue is that @elasticsearchmachine needs access as well in order to update the status. Typically we just add @elastic/continuous-integration . I'll do that, and rerun the job, and it should appear.

@gtback
Copy link
Member

gtback commented Sep 13, 2021

@elasticmachine run elasticsearch-ci/docs

@bmorelli25
Copy link
Member

Nice! Thank you, Greg!

@gtback
Copy link
Member

gtback commented Sep 13, 2021

I'll do that, and rerun the job, and it should appear.

Yep, it's running now.

@trentm trentm merged commit 9b4f08b into elastic:master Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants