-
Notifications
You must be signed in to change notification settings - Fork 40
Add a link to the Node.js ECS logging tutorial in the Cloud docs #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Trends 🧪 |
Jenkins, run the tests please |
@elasticmachine, run elasticsearch-ci/docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 🦖
Nice. It might also be nice to add a link to the bottom of the Winston setup section here: https://www.elastic.co/guide/en/ecs-logging/nodejs/master/winston.html#_setup_3 (repo file: https://github.com/elastic/ecs-logging-nodejs/blob/master/docs/winston.asciidoc), if you like. |
@bmorelli25 I this hooked up for this repo? I don't see a GH check that results from that request. |
It should be. The check was added in https://github.com/elastic/infra/pull/26395. |
@elasticmachine, run elasticsearch-ci/docs |
The webhook to trigger the build also exists already... 🤔 |
I must've missed something, somewhere... @gtback, do you see an obvious reason why docs ci won't run in this repo? |
Nope: That PR used the "...-nodejs" repo name. |
The jobs are running, but aren't able to report the status back; there are a bunch of jobs here for this PR. I believe the issue is that @elasticsearchmachine needs access as well in order to update the status. Typically we just add @elastic/continuous-integration . I'll do that, and rerun the job, and it should appear. |
@elasticmachine run elasticsearch-ci/docs |
Nice! Thank you, Greg! |
Yep, it's running now. |
This adds a link to a new Node.JS ECS logging tutorial in the Cloud docs.
@bmorelli25, or anyone, please let me know if you think there might be a better place for this link.