Add a link from winston ECS logging to a Cloud tutorial doc #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Trends 🧪 |
github-actions
bot
added
the
agent-nodejs
trentm
reviewed
Sep 10, 2021
docs/winston.asciidoc
Outdated
| @@ -265,3 +265,5 @@ const logger = winston.createLogger({ | |||
| // ... | |||
| }) | |||
| ---- | |||
|
|
|||
| To learn more, try out our tutorial using Node.js ECS logging with winston: {cloud}/ec-getting-started-search-use-cases-node-logs.html[Ingest logs from a Node.js web application using Filebeat]. | |||
There was a problem hiding this comment.
I think this would be better in the "Setup" section up higher. Could you move this up to just above these lines:
[float]
[[winston-usage]]
=== Usage
?
There was a problem hiding this comment.
Good idea. I moved the link up to the "Configure Filebeat" section.
Move the tutorial link up to the `Configure Filebeat` section.
trentm
approved these changes
Sep 10, 2021
|
jenkins run the tests |
|
@elasticmachine run elasticsearch-ci/docs |
trentm
approved these changes
Sep 13, 2021
|
Thanks for approving this! I'm not able to merge it but if there's anything I can do to help, let me know. |
|
Ah, I see it's merged now. Thanks @trentm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rel: #99
Adds a link at the bottom of this Node.js winston ECS logging page to a similar tutorial in the Cloud docs.