Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat] Don't use inet / be silent when setting up projects #34936

Merged
merged 3 commits into from
Mar 27, 2023
Merged

[Heartbeat] Don't use inet / be silent when setting up projects #34936

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9195509
Don't run npm audit when setting up projects
andrewvc Mar 27, 2023
a77ddc3
Add changelog
andrewvc Mar 27, 2023
240d412
Incorporate PR feedback
andrewvc Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.next.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ https://github.com/elastic/beats/compare/v8.2.0\...main[Check the HEAD diff]
with the ecs field name `container`. {pull}34403[34403]
automatic splitting at root level, if root level element is an array. {pull}34155[34155]
- Fix broken mapping for state.ends field. {pull}34891[34891]
- Fix issue using projects in airgapped environments by disabling npm audit. {pull}34936[34936]

*Heartbeat*

Expand Down
2 changes: 1 addition & 1 deletion x-pack/heartbeat/monitors/browser/source/project.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ func setupProjectDir(workdir string) error {
}

// setup the project linking to the global synthetics library
return runSimpleCommand(exec.Command("npm", "install"), workdir)
return runSimpleCommand(exec.Command("npm", "install", "--no-audit"), workdir)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add these options to speed the npm install script up.

audit=false
update-notifier=false
fetch-timeout=30000
fetch-retry-factor=0
package-lock=false
progress=false

We could also bake this inside a .npmrc file and run only npm install

}

func (p *ProjectSource) Workdir() string {
Expand Down