[Heartbeat] Don't use inet / be silent when setting up projects #34936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewvc
added
bug
Heartbeat
Team:obs-ds-hosted-services
botelastic
bot
added
the
needs_team
|
Pinging @elastic/uptime (Team:Uptime) |
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
| @@ -117,7 +117,7 @@ func setupProjectDir(workdir string) error { | |||
| } | |||
|
|
|||
| // setup the project linking to the global synthetics library | |||
| return runSimpleCommand(exec.Command("npm", "install"), workdir) | |||
| return runSimpleCommand(exec.Command("npm", "install", "--no-audit"), workdir) | |||
There was a problem hiding this comment.
We could add these options to speed the npm install script up.
audit=false
update-notifier=false
fetch-timeout=30000
fetch-retry-factor=0
package-lock=false
progress=false
We could also bake this inside a .npmrc file and run only npm install
andrewvc
changed the title
mergify bot
pushed a commit
that referenced
this pull request
Mar 27, 2023
Using the internet and performing other checks is unnecessary in this context, and just slows down what should be fast. Will need to be manually tested to ensure that no internet connection is needed in airgapped envs (cherry picked from commit 5ed7e8d)
andrewvc
added a commit
that referenced
this pull request
Mar 30, 2023
…) (#34944) Using the internet and performing other checks is unnecessary in this context, and just slows down what should be fast. Will need to be manually tested to ensure that no internet connection is needed in airgapped envs (cherry picked from commit 5ed7e8d) Co-authored-by: Andrew Cholakian <andrewvc@elastic.co>
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
Using the internet and performing other checks is unnecessary in this context, and just slows down what should be fast. Will need to be manually tested to ensure that no internet connection is needed in airgapped envs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the internet and performing other checks is unnecessary in this context, and just slows down what should be fast. Will need to be manually tested to ensure that no internet connection is needed in airgapped envs
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.