Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elastic-agent] Improve log messages (backport #25372) #25392

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 28, 2021

This is an automatic backport of pull request #25372 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

This PR improves the log messages to make them easier to consume by users.

* Change unroll to unenroll, that is what we use in the UI too
* Trigger unenroll only when the maxCounter is exceeded (nit)
* Move Artifact has been built with security disable to info. This only happens for internal builds
* Move log message around binary already exists to debug level as this is an expected behaviour
* Be more specific about binary downloads
* For state changes, move the message first. That is the most interesting part for a user

(cherry picked from commit 89d2b36)
@mergify mergify bot added the backport label Apr 28, 2021
@mergify mergify bot assigned ruflin Apr 28, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 28, 2021
@botelastic
Copy link

botelastic bot commented Apr 28, 2021

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #25392 opened

  • Start Time: 2021-04-28T15:03:37.438+0000

  • Duration: 68 min 42 sec

  • Commit: dc88805

Test stats 🧪

Test Results
Failed 0
Passed 6740
Skipped 24
Total 6764

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6740
Skipped 24
Total 6764

@ruflin ruflin merged commit 86c4631 into 7.x Apr 28, 2021
@ruflin ruflin deleted the mergify/bp/7.x/pr-25372 branch April 28, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants