[elastic-agent] Improve log messages #25372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR improves the log messages to make them easier to consume by users. * Change unroll to unenroll, that is what we use in the UI too * Trigger unenroll only when the maxCounter is exceeded (nit) * Move Artifact has been built with security disable to info. This only happens for internal builds * Move log message around binary already exists to debug level as this is an expected behaviour * Be more specific about binary downloads * For state changes, move the message first. That is the most interesting part for a user
ruflin
added
Team:Elastic-Agent
|
Pinging @elastic/agent (Team:Agent) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
blakerouse
approved these changes
Apr 28, 2021
mergify bot
pushed a commit
that referenced
this pull request
Apr 28, 2021
This PR improves the log messages to make them easier to consume by users. * Change unroll to unenroll, that is what we use in the UI too * Trigger unenroll only when the maxCounter is exceeded (nit) * Move Artifact has been built with security disable to info. This only happens for internal builds * Move log message around binary already exists to debug level as this is an expected behaviour * Be more specific about binary downloads * For state changes, move the message first. That is the most interesting part for a user (cherry picked from commit 89d2b36)
mergify bot
pushed a commit
that referenced
this pull request
Apr 28, 2021
This PR improves the log messages to make them easier to consume by users. * Change unroll to unenroll, that is what we use in the UI too * Trigger unenroll only when the maxCounter is exceeded (nit) * Move Artifact has been built with security disable to info. This only happens for internal builds * Move log message around binary already exists to debug level as this is an expected behaviour * Be more specific about binary downloads * For state changes, move the message first. That is the most interesting part for a user (cherry picked from commit 89d2b36)
ruflin
added a commit
that referenced
this pull request
Apr 28, 2021
This PR improves the log messages to make them easier to consume by users. * Change unroll to unenroll, that is what we use in the UI too * Trigger unenroll only when the maxCounter is exceeded (nit) * Move Artifact has been built with security disable to info. This only happens for internal builds * Move log message around binary already exists to debug level as this is an expected behaviour * Be more specific about binary downloads * For state changes, move the message first. That is the most interesting part for a user (cherry picked from commit 89d2b36) Co-authored-by: Nicolas Ruflin <spam@ruflin.com>
ruflin
added a commit
that referenced
this pull request
Apr 28, 2021
This PR improves the log messages to make them easier to consume by users. * Change unroll to unenroll, that is what we use in the UI too * Trigger unenroll only when the maxCounter is exceeded (nit) * Move Artifact has been built with security disable to info. This only happens for internal builds * Move log message around binary already exists to debug level as this is an expected behaviour * Be more specific about binary downloads * For state changes, move the message first. That is the most interesting part for a user (cherry picked from commit 89d2b36) Co-authored-by: Nicolas Ruflin <spam@ruflin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the log messages to make them easier to consume by users.