[Filebeat] Improve validation check for Azure configuration #20389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leehinman
added
bug
Filebeat
|
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
added
needs_team
A blob container name must be between 3 and 63 characters in length; start with a letter or number; and contain only letters, numbers, and the hyphen. All letters used in blob container names must be lowercase. Added validation to make sure the storage container name meets those requirements. Closes elastic#20369
leehinman
force-pushed
the
20369_azure_config
branch
from
1275d9d
to
44bf6bb
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
Merged
4 tasks
leehinman
added
v7.10.0
and removed
needs_backport
leehinman
added a commit
to leehinman/beats
that referenced
this pull request
Aug 10, 2020
A blob container name must be between 3 and 63 characters in length; start with a letter or number; and contain only letters, numbers, and the hyphen. All letters used in blob container names must be lowercase. Added validation to make sure the storage container name meets those requirements. Closes elastic#20369 (cherry picked from commit 7913005)
leehinman
added a commit
that referenced
this pull request
Aug 10, 2020
A blob container name must be between 3 and 63 characters in length; start with a letter or number; and contain only letters, numbers, and the hyphen. All letters used in blob container names must be lowercase. Added validation to make sure the storage container name meets those requirements. Closes #20369 (cherry picked from commit 7913005)
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
A blob container name must be between 3 and 63 characters in length; start with a letter or number; and contain only letters, numbers, and the hyphen. All letters used in blob container names must be lowercase. Added validation to make sure the storage container name meets those requirements. Closes elastic#20369
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
An Azure blob container name must be between 3 and 63 characters in
length; start with a letter or number; and contain only letters,
numbers, and the hyphen. All letters used in blob container names must
be lowercase. Added validation to make sure the storage container
name meets those requirements.
Why is it important?
The default storage container name is made by appending "filebeat-" to
the eventhub name. But the eventhub name may contain invalid
characters or prepending "filebeat-" may make the name too long. If
either of those occur the user receives an error that the resource
name is invalid but no clear indication as to what is wrong or how to
fix. This validation will help guide the user to a valid storage
container name.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Related issues