Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #20389 to 7.x: [Filebeat] Improve validation check for Azure configuration #20515

Merged
merged 1 commit into from
Aug 10, 2020

Conversation

leehinman
Copy link
Contributor

@leehinman leehinman commented Aug 10, 2020

Cherry-pick of PR #20389 to 7.x branch. Original message:

What does this PR do?

An Azure blob container name must be between 3 and 63 characters in
length; start with a letter or number; and contain only letters,
numbers, and the hyphen. All letters used in blob container names must
be lowercase. Added validation to make sure the storage container
name meets those requirements.

Why is it important?

The default storage container name is made by appending "filebeat-" to
the eventhub name. But the eventhub name may contain invalid
characters or prepending "filebeat-" may make the name too long. If
either of those occur the user receives an error that the resource
name is invalid but no clear indication as to what is wrong or how to
fix. This validation will help guide the user to a valid storage
container name.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

go test

Related issues

A blob container name must be between 3 and 63 characters in length;
start with a letter or number; and contain only letters, numbers, and
the hyphen. All letters used in blob container names must be
lowercase.  Added validation to make sure the storage container name
meets those requirements.

Closes elastic#20369

(cherry picked from commit 7913005)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 10, 2020
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20515 opened]

  • Start Time: 2020-08-10T14:50:01.588+0000

  • Duration: 56 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 2438
Skipped 385
Total 2823

@leehinman leehinman merged commit 8be5594 into elastic:7.x Aug 10, 2020
@leehinman leehinman deleted the backport_20389_7.x branch October 5, 2020 19:06
@zube zube bot removed the [zube]: Done label Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants