Cherry-pick #13808 to 7.6: Fix renaming cloud metadata processor fields #18356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
Clone the underlying metadata to allow renaming sub-fields under cloud that are injected by the cloud metadata processor. (cherry picked from commit 6785901)
jsoriano
force-pushed
the
backport_13808_7.6
branch
from
d2c7b03
to
265aec3
Compare
kaiyan-sheng
approved these changes
May 7, 2020
|
Thanks for backporting this to 7.6! |
|
Umm, tests running in ubuntu workers have failed because it was trying to use python3 🤔 Trying to set PYTHON_EXE to python2 by default in Makefiles to see if this fixes this issue. |
|
I am reverting the changes for python 2 and merging, there are more things that should be fixed in tests, but I don't think that this fix affects any of them. |
jsoriano
force-pushed
the
backport_13808_7.6
branch
from
1309b6d
to
265aec3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #13808 to 7.6 branch. Original message:
Clone the underlying metadata to allow renaming sub-fields under cloud
that are injected by the cloud metadata processor.
Without cloning the injected metadata,
renameand possibly other processors fail to operate on the sub-fields of the injectedcloudfield.Further details can be found in the community post: https://discuss.elastic.co/t/cannot-rename-sub-fields-of-cloud-metadata-added-via-add-cloud-metadata/201157.