Fix renaming cloud metadata processor fields #13808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jalaziz
force-pushed
the
fix-cloud-metadata-rename
branch
from
17d6735
to
985d1c2
Compare
jalaziz
force-pushed
the
fix-cloud-metadata-rename
branch
from
985d1c2
to
df5329d
Compare
|
Any chance of this getting reviewed soon? |
|
Sorry for the delay. This looks good to me (besides the conflict). @adriansr Could you take a look as well please? |
Clone the underlying metadata to allow renaming sub-fields under cloud that are injected by the cloud metadata processor.
jalaziz
force-pushed
the
fix-cloud-metadata-rename
branch
from
df5329d
to
10a8f25
Compare
|
Rebased to fix the conflict. |
kaiyan-sheng
added
the
needs_backport
adriansr
approved these changes
Nov 13, 2019
andrewkroh
approved these changes
Nov 14, 2019
|
jenkins, test this |
kaiyan-sheng
added
the
Team:Platforms
|
jenkins, test this please |
kaiyan-sheng
added
v7.7.0
and removed
needs_backport
jsoriano
pushed a commit
to jsoriano/beats
that referenced
this pull request
May 7, 2020
Clone the underlying metadata to allow renaming sub-fields under cloud that are injected by the cloud metadata processor. (cherry picked from commit 6785901)
jsoriano
pushed a commit
to jsoriano/beats
that referenced
this pull request
May 7, 2020
Clone the underlying metadata to allow renaming sub-fields under cloud that are injected by the cloud metadata processor. (cherry picked from commit 6785901)
Yep, #17968 seems to be fixed by this. I have opened backports for 7.6 and 6.8 too. |
jsoriano
added a commit
that referenced
this pull request
May 8, 2020
Clone the underlying metadata to allow renaming sub-fields under cloud that are injected by the cloud metadata processor. (cherry picked from commit 6785901) Co-authored-by: Jameel Al-Aziz <247849+jalaziz@users.noreply.github.com>
jsoriano
added a commit
that referenced
this pull request
May 8, 2020
Clone the underlying metadata to allow renaming sub-fields under cloud that are injected by the cloud metadata processor. (cherry picked from commit 6785901) Co-authored-by: Jameel Al-Aziz <247849+jalaziz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clone the underlying metadata to allow renaming sub-fields under cloud
that are injected by the cloud metadata processor.
Without cloning the injected metadata,
renameand possibly other processors fail to operate on the sub-fields of the injectedcloudfield.Further details can be found in the community post: https://discuss.elastic.co/t/cannot-rename-sub-fields-of-cloud-metadata-added-via-add-cloud-metadata/201157.