-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update stale references to _xpack to refer to _license instead #18030
Merged
ycombinator
merged 2 commits into
elastic:master
from
ycombinator:xp-lb-licenser-endpoints
Apr 28, 2020
Merged
Update stale references to _xpack to refer to _license instead #18030
ycombinator
merged 2 commits into
elastic:master
from
ycombinator:xp-lb-licenser-endpoints
Apr 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
bug
libbeat
needs_backport
PR is waiting to be backported to other branches.
v8.0.0
x-pack
Issues and pull requests for X-Pack features.
Team:Services
(Deprecated) Label for the former Integrations-Services team
v7.8.0
v7.7.1
labels
Apr 27, 2020
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Apr 27, 2020
ph
approved these changes
Apr 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing this.
This was referenced Apr 28, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Apr 28, 2020
…unbld * upstream/master: ci: comment PRs with the build status (elastic#17971) Add domain state metricset to kvm module (elastic#17673) [Agent] Allow CLI paths override (elastic#17781) Fix generated metricbeat so create-metricset works. (elastic#18020) LIBBEAT: Enhancement replace_string processor for replacing strings values of fields. (elastic#17342) Update stale references to _xpack to refer to _license instead (elastic#18030) Review dependency patterns collection in Jenkins (elastic#18004)
ycombinator
added a commit
that referenced
this pull request
Apr 30, 2020
… (#18044) * Update stale references to _xpack to refer to _license instead * Adding CHANGELOG entry
ycombinator
added a commit
that referenced
this pull request
Apr 30, 2020
… (#18045) * Update stale references to _xpack to refer to _license instead * Adding CHANGELOG entry
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…ic#18030) (elastic#18045) * Update stale references to _xpack to refer to _license instead * Adding CHANGELOG entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
libbeat
needs_backport
PR is waiting to be backported to other branches.
Team:Services
(Deprecated) Label for the former Integrations-Services team
v7.7.1
v7.8.0
v8.0.0
x-pack
Issues and pull requests for X-Pack features.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates an error message emitted by the Licenser code in X-Pack Libbeat to reference the
_license
endpoint. Also updates identifier names and comments in related code.Why is it important?
Starting
7.0.0
, the_xpack/license
Elasticsearch endpoint was superseded by the_license
endpoint. The Licenser code in X-Pack Libbeat was updated to use the new endpoint in #15091. However, it looks like a couple of references to the old endpoint were still left around, including one in an error message. Seeing this old endpoint in the error message causes confusion.Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues