Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stale references to _xpack to refer to _license instead #18030

Merged
merged 2 commits into from
Apr 28, 2020

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Apr 27, 2020

What does this PR do?

Updates an error message emitted by the Licenser code in X-Pack Libbeat to reference the _license endpoint. Also updates identifier names and comments in related code.

Why is it important?

Starting 7.0.0, the _xpack/license Elasticsearch endpoint was superseded by the _license endpoint. The Licenser code in X-Pack Libbeat was updated to use the new endpoint in #15091. However, it looks like a couple of references to the old endpoint were still left around, including one in an error message. Seeing this old endpoint in the error message causes confusion.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@ycombinator ycombinator added bug libbeat needs_backport PR is waiting to be backported to other branches. v8.0.0 x-pack Issues and pull requests for X-Pack features. Team:Services (Deprecated) Label for the former Integrations-Services team v7.8.0 v7.7.1 labels Apr 27, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 27, 2020
@ycombinator ycombinator requested a review from ph April 27, 2020 23:45
@andresrc andresrc removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 28, 2020
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this.

@ycombinator ycombinator merged commit 164beb0 into elastic:master Apr 28, 2020
@ycombinator ycombinator deleted the xp-lb-licenser-endpoints branch April 28, 2020 12:08
v1v added a commit to v1v/beats that referenced this pull request Apr 28, 2020
…unbld

* upstream/master:
  ci: comment PRs with the build status (elastic#17971)
  Add domain state metricset to kvm module (elastic#17673)
  [Agent] Allow CLI paths override (elastic#17781)
  Fix generated metricbeat so create-metricset works. (elastic#18020)
  LIBBEAT: Enhancement replace_string processor for replacing strings values of fields. (elastic#17342)
  Update stale references to _xpack to refer to _license instead (elastic#18030)
  Review dependency patterns collection in Jenkins (elastic#18004)
ycombinator added a commit that referenced this pull request Apr 30, 2020
… (#18044)

* Update stale references to _xpack to refer to _license instead

* Adding CHANGELOG entry
ycombinator added a commit that referenced this pull request Apr 30, 2020
… (#18045)

* Update stale references to _xpack to refer to _license instead

* Adding CHANGELOG entry
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…ic#18030) (elastic#18045)

* Update stale references to _xpack to refer to _license instead

* Adding CHANGELOG entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug libbeat needs_backport PR is waiting to be backported to other branches. Team:Services (Deprecated) Label for the former Integrations-Services team v7.7.1 v7.8.0 v8.0.0 x-pack Issues and pull requests for X-Pack features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libbeat licenser error references /_xpack endpoint
4 participants