[Agent] Allow CLI paths override #17781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ingest-management (Project:fleet) |
|
not ready for review, libbeat is bugging me with global use of flags |
ph
suggested changes
Apr 22, 2020
| ) | ||
|
|
||
| func init() { | ||
| homePath = retrieveExecutablePath() | ||
| dataPath = retrieveDataPath() | ||
| overwrites = common.SettingFlag(nil, "E", "Configuration overwrite") | ||
| common.ConfigOverwriteFlag(nil, overwrites, "path.home", "path.home", "", "Agent root path") | ||
| common.ConfigOverwriteFlag(nil, overwrites, "path.data", "path.data", "", "Data path, agent usually look for beats here") |
There was a problem hiding this comment.
rename Data path, agent usually look for beats here to Data path contains Agent managed binary")
| @@ -50,11 +50,12 @@ func NewCommandWithArgs(args []string, streams *cli.IOStreams) *cobra.Command { | |||
|
|
|||
| flags := &globalFlags{} | |||
|
|
|||
| cmd.PersistentFlags().AddGoFlag(flag.CommandLine.Lookup("E")) | |||
There was a problem hiding this comment.
I don't see code to make this work?
|
@michalpristas for -E lets make it a followup issue, Is there anything that could prevent us to support it ? |
|
@michalpristas I have testes this locally with |
ph
approved these changes
Apr 24, 2020
|
Linked #17967 |
v1v
added a commit
to v1v/beats
that referenced
this pull request
Apr 28, 2020
…unbld * upstream/master: ci: comment PRs with the build status (elastic#17971) Add domain state metricset to kvm module (elastic#17673) [Agent] Allow CLI paths override (elastic#17781) Fix generated metricbeat so create-metricset works. (elastic#18020) LIBBEAT: Enhancement replace_string processor for replacing strings values of fields. (elastic#17342) Update stale references to _xpack to refer to _license instead (elastic#18030) Review dependency patterns collection in Jenkins (elastic#18004)
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
May 4, 2020
[Agent] Allow CLI paths override (elastic#17781)
6 tasks
michalpristas
added a commit
that referenced
this pull request
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allowing override of configuration using
-Eflag of two specific cases--path.data--path.homeWhy is it important?
Allows having data (download, install) outside of agent directory without manually changing configuration file
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.