Implement check and add headers in mage #13215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Aug 9, 2019
houndci-bot
reviewed
Aug 9, 2019
houndci-bot
reviewed
Aug 9, 2019
jsoriano
commented
Aug 9, 2019
| @@ -0,0 +1,255 @@ | |||
| // Licensed to Elasticsearch B.V. under one or more contributor | |||
There was a problem hiding this comment.
This file is verbatim copied from https://github.com/elastic/go-txfile/tree/master/dev-tools/lib/mage/gotool
There was a problem hiding this comment.
At the end I changed it so same flag can be specified multiple times, what was needed for go-licenser when multiple -excludes are needed.
Closed
This was referenced Aug 14, 2019
|
jenkins, test this again please |
andrewkroh
reviewed
Aug 14, 2019
There was a problem hiding this comment.
Would you consider integrating this into the dev-tools/mage/target/common's Check() and Fmt() too?
And instead of adding AddLicenseHeaders and CheckLicenseHeaders to each project you could update all the projects to have a mage import like
import (
...
// mage:import
_ "github.com/elastic/beats/dev-tools/mage/target/common"
)
andrewkroh
reviewed
Aug 14, 2019
|
I will continue with this after #13239 |
jsoriano
added
in progress
jsoriano
added
review
and removed
in progress
|
@andrewkroh @urso this would be ready for another look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a framework to wrap go tooling in mage, taken from go-txtfile.
Using it, reimplements all uses of go-licenser in mage.
go-licenser is vendored.
Replaces #13211, see comments there for more context.