Vendorize go-licenser #13211
Vendorize go-licenser #13211
Conversation
jsoriano
force-pushed
the
go-licenser-vendor
branch
from
6b36962 to
5d8a774
Compare
jsoriano
force-pushed
the
go-licenser-vendor
branch
from
5d8a774 to
972974a
Compare
|
jenkins, test this again please |
| } | ||
|
|
||
| return nil | ||
| } |
There was a problem hiding this comment.
how about collecting go tooling into a separate package.
For example: https://github.com/elastic/go-txfile/blob/master/dev-tools/lib/mage/gotool/go.go
Samples how it's used:
There was a problem hiding this comment.
It would be better, yes. But I guess this is out of the scope of this PR?
We'd have to discuss where this package lives so it can be reused by the different projects.
There was a problem hiding this comment.
I'm fine with having it in the beats repo only for now. No worries about a little code duplication between go-txfile and beats.
| @@ -132,14 +133,14 @@ check: check-headers python-env prepare-tests ## @build Checks project and sourc | |||
| .PHONY: $(.OVER)check-headers | |||
| $(.OVER)check-headers: | |||
| ifndef CHECK_HEADERS_DISABLED | |||
| @go get -u github.com/elastic/go-licenser | |||
| @go get $(GO_LICENSER_REPO) | |||
| @go-licenser -d -license ${LICENSE} | |||
| endif | |||
There was a problem hiding this comment.
I know it's a little out of scope, but constant dripping wears away the stone. Can we move check-headers to mage? Mage should also be able to get dependencies.
|
Closing this as in principle we will go in the line of #13215 |
Current master is breaking builds, vendorize previous version.
Add mage helper for go get encouraging the use of vendorized dependencies.