Skip to content

Clarifications to S3 tracing spec #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2021
Merged

Clarifications to S3 tracing spec #451

merged 3 commits into from
Jun 16, 2021

Conversation

trentm
Copy link
Member

@trentm trentm commented Jun 15, 2021

@AlexanderWert Here are some clarifications to the S3 tracing spec. I assume some of these were copypasta from the DynamoDB section. Some removal of trailing whitespace is included in this diff (sorry about that), so this will be a slightly cleaner diff: https://github.com/elastic/apm/pull/451/files?w=1

Rendered: https://github.com/elastic/apm/blob/trentm/s3-copypasta/specs/agents/tracing-instrumentation-db.md#aws-s3

(I have some non-trivial Qs about the spec but I'll ask those separately.)

@trentm trentm self-assigned this Jun 15, 2021
@trentm trentm requested review from a team as code owners June 15, 2021 21:23
@trentm trentm requested a review from AlexanderWert June 15, 2021 21:23
@apmmachine
Copy link

apmmachine commented Jun 15, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #451 updated

  • Start Time: 2021-06-16T16:44:05.365+0000

  • Duration: 3 min 51 sec

  • Commit: dc52a84

Trends 🧪

Image of Build Times

Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @trentm 👍

Copy link
Member

@AlexanderWert AlexanderWert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trentm.

In general LGTM, maybe let's wait with merging until we decided what to do with context.db for S3.

@trentm
Copy link
Member Author

trentm commented Jun 16, 2021

maybe let's wait with merging until we decided what to do with context.db for S3.

For others following, Alexander and I discussed separately and decided to merge this and I'll have another PR later with more substantive changes (like proposing dropping span.context.db.* for S3) after some more discussion.

[From the process doc]

  1. The PR can be merged by the author of the PR
    One business day before merging, there should be a last call for objections.
    This last call is not mandatory and is a good candidate for being automated in the future.

I don't think this PR is contentious. Also it doesn't appear that the Go, Python, or Ruby agents (the one who've currently implemented S3 instrumentation) add span.context.db.* for S3 spans, so the change in the spec here doesn't affect current implementations.

@trentm trentm merged commit 17ff2f4 into master Jun 16, 2021
@trentm trentm deleted the trentm/s3-copypasta branch June 16, 2021 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants