-
Notifications
You must be signed in to change notification settings - Fork 116
Clarifications to S3 tracing spec #451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Trends 🧪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @trentm 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @trentm.
In general LGTM, maybe let's wait with merging until we decided what to do with context.db
for S3.
For others following, Alexander and I discussed separately and decided to merge this and I'll have another PR later with more substantive changes (like proposing dropping [From the process doc]
I don't think this PR is contentious. Also it doesn't appear that the Go, Python, or Ruby agents (the one who've currently implemented S3 instrumentation) add |
@AlexanderWert Here are some clarifications to the S3 tracing spec. I assume some of these were copypasta from the DynamoDB section. Some removal of trailing whitespace is included in this diff (sorry about that), so this will be a slightly cleaner diff: https://github.com/elastic/apm/pull/451/files?w=1
Rendered: https://github.com/elastic/apm/blob/trentm/s3-copypasta/specs/agents/tracing-instrumentation-db.md#aws-s3
(I have some non-trivial Qs about the spec but I'll ask those separately.)