Skip to content

Commit dc52a84

Browse files
authored
Merge branch 'master' into trentm/s3-copypasta
2 parents 62a0d16 + 611abe1 commit dc52a84

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

specs/agents/metrics.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,3 +55,8 @@ When capturing runtime metrics, keep in mind the end use-case: how will they be
5555
### Transaction and span breakdown
5656

5757
Agents should record "breakdown metrics", which is a summarisation of how much time is spent per span type/subtype in each transaction group. This is described in detail in the [Breakdown Graphs](https://docs.google.com/document/d/1-_LuC9zhmva0VvLgtI0KcHuLzNztPHbcM0ZdlcPUl64#heading=h.ondan294nbpt) document, so we do not repeat it here.
58+
59+
## Shutdown behavior
60+
61+
Agents should make an effort to flush any metrics before shutting down.
62+
If this cannot be achieved with shutdown hooks provided by the language/runtime, the agent should provide a public API that the user can call to flush any remaining data.

specs/agents/process-spec.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ Every change that affects more than one agent should be initiated via a PR again
2424
After at least one more agent and one PM has approved, others have 1 week to veto by requesting changes.
2525
If the proposed changes are likely to be problematic for a certain agent,
2626
an approval from that agent is mandatory.
27+
If the author of the PR deems the impact on product as negligible, approval by PM can be skipped.
28+
In such a case, make sure to note in the PR that you intend to skip PM approval.
2729
1. Prioritization \
2830
At any point in time,
2931
but before merging the PR,

0 commit comments

Comments
 (0)