add optional fields span.subtype and span.action #1618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roncohen
force-pushed
the
span-types
branch
2 times, most recently
from
4510a73 to
ca8243e
Compare
added 2 commits
December 4, 2018 17:49
simitt
approved these changes
Dec 4, 2018
roncohen
pushed a commit
to roncohen/kibana
that referenced
this pull request
Dec 4, 2018
|
agents sending subtype and action to a 6.4 install will see their requests rejected, right? this could use a changelog entry, if it didn't get one |
|
The Intake API allows additional fields, so Good point regarding the changelog. |
|
thanks! will add change log entry |
roncohen
pushed a commit
to roncohen/apm-server
that referenced
this pull request
Dec 5, 2018
roncohen
added a commit
to roncohen/apm-server
that referenced
this pull request
Dec 5, 2018
roncohen
added a commit
to roncohen/apm-server
that referenced
this pull request
Dec 5, 2018
roncohen
added a commit
to roncohen/kibana
that referenced
this pull request
Dec 5, 2018
roncohen
added a commit
that referenced
this pull request
Dec 5, 2018
roncohen
added a commit
to elastic/kibana
that referenced
this pull request
Dec 5, 2018
roncohen
added a commit
that referenced
this pull request
Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing #1617 (global issue: elastic/apm#8) on the server