More Py3.12 fixes #1900
Merged
More Py3.12 fixes #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that py3.12's gzip implementation is more efficient, and as a result the tests against `api_request_size` were failing. This change should still work against older versions, as I also increased the "don't send" test case.
trentm
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kafka-pythontests pending Workaround an error to import "range" from "kafka.vendor.six.moves" dpkp/kafka-python#2376api_request_sizetests that fail locally. Is 3.12's gzip implementation more efficient?Known issues:
As with the last py3.12 PR, the PR tests actually don't touch 3.12, so we'll merge this and see what the nightlies do.