Skip to content

Remote config #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 17, 2019
Merged

Remote config #640

merged 10 commits into from
Jul 17, 2019

Conversation

felixbarny
Copy link
Member

@felixbarny felixbarny commented May 21, 2019

closes #636

@codecov-io
Copy link

codecov-io commented May 28, 2019

Codecov Report

Merging #640 into master will increase coverage by 0.23%.
The diff coverage is 40%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #640      +/-   ##
===========================================
+ Coverage     66.67%   66.9%   +0.23%     
- Complexity       85      86       +1     
===========================================
  Files           209     209              
  Lines          9356    9515     +159     
  Branches       1329    1336       +7     
===========================================
+ Hits           6238    6366     +128     
- Misses         2774    2795      +21     
- Partials        344     354      +10
Impacted Files Coverage Δ Complexity Δ
...lastic/apm/agent/report/ReporterConfiguration.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...pm/agent/report/IntakeV2ReportingEventHandler.java 79.77% <0%> (-1.82%) 0 <0> (ø)
.../quartz/job/JobTransactionNameInstrumentation.java 100% <100%> (ø) 0 <0> (ø) ⬇️
...apm/agent/quartz/job/JobTransactionNameAdvice.java 4.16% <4.16%> (ø) 0 <0> (ø) ⬇️
...ic/apm/agent/slf4j/Slf4JMdcActivationListener.java 89.13% <76.92%> (+11.08%) 0 <0> (ø) ⬇️
...iguration/PrefixingConfigurationSourceWrapper.java 41.66% <0%> (-16.67%) 0% <0%> (ø)
...stic/apm/agent/jdbc/signature/SignatureParser.java 91.48% <0%> (-2.89%) 0% <0%> (ø)
...va/co/elastic/apm/agent/impl/ElasticApmTracer.java 74.57% <0%> (-2.41%) 0% <0%> (-14%)
...astic/apm/agent/report/ApmServerHealthChecker.java 54.54% <0%> (-1.82%) 0% <0%> (ø)
...astic/apm/agent/impl/transaction/TraceContext.java 88.34% <0%> (-1.8%) 18% <0%> (+18%)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7865146...63f25f6. Read the comment docs.

@jalvz
Copy link

jalvz commented May 28, 2019

depends on elastic/apm-server#2095

@felixbarny felixbarny marked this pull request as ready for review June 18, 2019 14:27
Copy link
Contributor

@eyalkoren eyalkoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

The recent decision to enable polling configuration on the APM server requires some changes. Not a big deal.

In addition, I think we need to see how we make this fit with the healthcheck, retrying with different servers etc.

Copy link
Contributor

@eyalkoren eyalkoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Very good comments and tests!
Few minor comments.

throw previousException;
}

public void executeForAllUrls(String path, ConnectionHandler<Void> connectionHandler) throws Exception {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to reuse common code with execute

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new changes, the logic is quite different now.

@felixbarny felixbarny merged commit 8aaaf6a into elastic:master Jul 17, 2019
@felixbarny felixbarny deleted the central-configuration branch July 17, 2019 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote config
4 participants