-
Notifications
You must be signed in to change notification settings - Fork 324
Remote config #640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote config #640
Conversation
closes elastic#636
apm-agent-core/src/main/java/co/elastic/apm/agent/impl/ElasticApmTracerBuilder.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #640 +/- ##
===========================================
+ Coverage 66.67% 66.9% +0.23%
- Complexity 85 86 +1
===========================================
Files 209 209
Lines 9356 9515 +159
Branches 1329 1336 +7
===========================================
+ Hits 6238 6366 +128
- Misses 2774 2795 +21
- Partials 344 354 +10
Continue to review full report at Codecov.
|
...gent-core/src/main/java/co/elastic/apm/agent/configuration/ApmServerConfigurationSource.java
Outdated
Show resolved
Hide resolved
depends on elastic/apm-server#2095 |
...gent-core/src/main/java/co/elastic/apm/agent/configuration/ApmServerConfigurationSource.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
The recent decision to enable polling configuration on the APM server requires some changes. Not a big deal.
In addition, I think we need to see how we make this fit with the healthcheck, retrying with different servers etc.
...gent-core/src/main/java/co/elastic/apm/agent/configuration/ApmServerConfigurationSource.java
Outdated
Show resolved
Hide resolved
apm-agent-core/src/main/java/co/elastic/apm/agent/impl/ElasticApmTracerBuilder.java
Outdated
Show resolved
Hide resolved
...gent-core/src/main/java/co/elastic/apm/agent/configuration/ApmServerConfigurationSource.java
Outdated
Show resolved
Hide resolved
...gent-core/src/main/java/co/elastic/apm/agent/configuration/ApmServerConfigurationSource.java
Outdated
Show resolved
Hide resolved
apm-agent-core/src/main/java/co/elastic/apm/agent/report/ApmServerHealthChecker.java
Outdated
Show resolved
Hide resolved
apm-agent-core/src/test/java/co/elastic/apm/agent/metrics/builtin/SystemMetricsTest.java
Outdated
Show resolved
Hide resolved
...-core/src/test/java/co/elastic/apm/agent/configuration/ApmServerConfigurationSourceTest.java
Show resolved
Hide resolved
- Determine polling interval based on Cache-Control: max-age value - refactor ApmServerClient
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Very good comments and tests!
Few minor comments.
...gent-core/src/main/java/co/elastic/apm/agent/configuration/ApmServerConfigurationSource.java
Show resolved
Hide resolved
throw previousException; | ||
} | ||
|
||
public void executeForAllUrls(String path, ConnectionHandler<Void> connectionHandler) throws Exception { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to reuse common code with execute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the new changes, the logic is quite different now.
closes #636