Return an error when container runtime and overrideBootstrapCommand are defined together

[Skarlso]

Description

Closes #5363

Checklist

• Added tests that cover your change (if possible)
• Added/modified documentation as required (such as the README.md, or the userdocs directory)
• Manually tested
• Made sure the title of the PR is a good description that can go into the release notes
• (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

• Backfilled missing tests for code in same general area 🎉
• Refactored something and made the world a better place 🌟

[Himangini]

Can you add the output of manual test run?

Small nit for the title to go in release notes :
Return an error in case container runtime and overrideBootstrapCommand is defined should be
Return an error when container runtime and overrideBootstrapCommand are defined together

[Skarlso]

Manual run:

eksctl create cluster -f cluster-managed.yaml
Error: overrideBootstrapCommand overwrites container runtime setting; please use --container-runtime in the boostrap script instead

config:

apiVersion: eksctl.io/v1alpha5
kind: ClusterConfig

metadata:
  name: gb-test-cluster-2
  region: us-west-2
  version: '1.22'

nodeGroups:
  - name: managed-ng-1
    ami: ami-12345
    amiFamily: AmazonLinux2
    minSize: 1
    maxSize: 4
    desiredCapacity: 1
    containerRuntime: containerd
    overrideBootstrapCommand: |
      #!/bin/bash

      source /var/lib/cloud/scripts/eksctl/bootstrap.helper.sh

      # Note "--node-labels=${NODE_LABELS}" needs the above helper sourced to work, otherwise will have to be defined manually.
      /etc/eks/bootstrap.sh test-override-11 --container-runtime containerd --kubelet-extra-args "--node-labels=${NODE_LABELS}"

[Himangini]

🎉

[steffakasid]

This seems to be broken in 0.105.0-dev+aa76f1d4.2022-07-08T14:38:11Z I've not set the containerRuntime config option and instead set it viw overrideBootstrapComman. But I still see the error message: "Error: overrideBootstrapCommand overwrites container runtime setting; please use --container-runtime in the bootsrap script instead".

[steffakasid]

Little correction it seems it throws the error when using the eksctl scale nodegroup command creation of nodegroups eksctl create nodegroup works fine. Should I create an issue for that?

[Skarlso]

Hello @steffakasid!

Yes, please! Thank you! :)