Skip to content

Conversation

@nikimanoledaki
Copy link
Contributor

@nikimanoledaki nikimanoledaki commented Jul 22, 2022

Description

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@nikimanoledaki nikimanoledaki added the skip-release-notes Causes PR not to show in release notes label Jul 22, 2022
@nikimanoledaki nikimanoledaki requested review from Himangini and cPu1 July 22, 2022 12:40
@nikimanoledaki nikimanoledaki merged commit b204c3c into eksctl-io:main Jul 22, 2022
@nikimanoledaki nikimanoledaki deleted the notes branch July 22, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Causes PR not to show in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants