Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Testes e pequenas correções de bugs #575

Merged
merged 21 commits into from
Nov 1, 2018

Conversation

fabiolamfleury
Copy link
Member

@fabiolamfleury fabiolamfleury commented Oct 18, 2018

Descrição

Criação de testes em apps do ej que possuem menor cobertura.
Durante a criação de testes foi encontrado um bug no arquivo math.py do ej_clusters, que ainda usava um filtro do atributo username de user (que existe agora como propriedade) esse bug foi corrigido nessa branch!

Issues Relacionadas

resolves: #250
resolves: #603

Checklist

  • Os commits seguem o padrão do projeto (Flake8 e afins)
  • Os testes estão passando e cobrem as mudanças
  • Marcou no título do pull request se ele é work in progress [WIP] ou se está pronto para revisão [REVIEW]

@codecov
Copy link

codecov bot commented Oct 18, 2018

Codecov Report

Merging #575 into develop will increase coverage by 8.33%.
The diff coverage is 90%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #575      +/-   ##
===========================================
+ Coverage    73.47%   81.81%   +8.33%     
===========================================
  Files          121      121              
  Lines         3220     3201      -19     
  Branches       347      343       -4     
===========================================
+ Hits          2366     2619     +253     
+ Misses         752      482     -270     
+ Partials       102      100       -2
Impacted Files Coverage Δ
src/ej_conversations/validators.py 60% <ø> (-6.67%) ⬇️
src/ej_conversations/roles.py 66.66% <ø> (-0.73%) ⬇️
src/ej_clusters/math.py 55.88% <0%> (+22.05%) ⬆️
src/ej_profiles/routes.py 98.03% <100%> (+34.4%) ⬆️
src/ej_clusters/routes.py 96.11% <100%> (+35.92%) ⬆️
src/ej_configurations/models.py 86.66% <100%> (-0.18%) ⬇️
src/ej_conversations/forms.py 100% <100%> (+40%) ⬆️
src/ej_configurations/validators.py 87.5% <90%> (+4.16%) ⬆️
src/ej/jinja2.py 76.92% <0%> (+1.92%) ⬆️
src/ej/roles/tags.py 73.91% <0%> (+2.17%) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7e12f3...e966344. Read the comment docs.

@fabiolamfleury fabiolamfleury changed the title [WIP] Increasing test coverage [WIP] Testes e pequenas correções de bugs Oct 19, 2018
@fabiolamfleury fabiolamfleury force-pushed the i250_increase_test_coverage branch 2 times, most recently from eda319f to 632ff10 Compare October 19, 2018 18:48
@fabiolamfleury fabiolamfleury requested a review from a team October 20, 2018 15:49
@fabiolamfleury fabiolamfleury changed the title [WIP] Testes e pequenas correções de bugs [REVIEW] Testes e pequenas correções de bugs Oct 31, 2018
@rodrigocam rodrigocam merged commit 0e98879 into develop Nov 1, 2018
@delete-merged-branch delete-merged-branch bot deleted the i250_increase_test_coverage branch November 1, 2018 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolver os bugs da clusterização Criar mais testes
3 participants