Improving code coverage

src/ej_configurations/models.py

@@ -7,10 +7,9 @@
 from boogie.fields import EnumField, Enum
 from hyperpython import a, div, Text
 
-from ej_conversations.validators import validate_color
 from .icons import default_icon_name
 from .sanitizer import sanitize_html
-from .validators import validate_icon_name
+from .validators import validate_icon_name, validate_color
 
 
 class Format(Enum):

src/ej_configurations/tests/test_models.py

@@ -1,5 +1,6 @@
 import pytest
 from django.db import IntegrityError
+from django.core.exceptions import ValidationError
 
 from ej_configurations.models import SocialMediaIcon, Color, Fragment
 
@@ -26,6 +27,15 @@ def color(self):
     def test_color_representation(self, color):
         assert str(color) == 'red: #FF0000'
 
+    def test_color_with_invalid_value(self, db):
+        color = Color(name='invalid', hex_value='*')
+        with pytest.raises(ValidationError):
+            color.full_clean()
+
+    def test_color_with_valid_value(self, db):
+        color = Color(name='invalid', hex_value='#FF0000')
+        color.full_clean()
+
 
 class TestFragment:
     @pytest.fixture

src/ej_configurations/validators.py

@@ -1,8 +1,24 @@
+import re
+
 from django.core.exceptions import ValidationError
 from django.utils.translation import ugettext as _
 
 from hyperpython.components.fa_icons import COLLECTIONS
 
+try:
+    from colortools import COLOR_NAMES
+
+    COLOR_NAMES = dict(COLOR_NAMES)
+except ImportError:
+    COLOR_NAMES = {}
+
+COLOR_RE = re.compile(r'^#[0-9A-Fa-f]{3,4}(?:[0-9A-Fa-f]{3,4})?$')
+
+
+def validate_color(color):
+    if not COLOR_RE.fullmatch(color) and color not in COLOR_NAMES:
+        raise ValidationError(_(f"'{color}' is a bad color value"))
+
 
 def validate_icon_name(icon_name):
     if icon_name not in COLLECTIONS:

src/ej_conversations/validators.py

@@ -1,22 +1,6 @@
-import re
-
 from django.core.exceptions import ValidationError
 from django.utils.translation import ugettext_lazy as _
 
-try:
-    from colortools import COLOR_NAMES
-
-    COLOR_NAMES = dict(COLOR_NAMES)
-except ImportError:
-    COLOR_NAMES = {}
-
-COLOR_RE = re.compile(r'^#[0-9A-Fa-f]{3,4}(?:[0-9A-Fa-f]{3,4})?$')
-
-
-def validate_color(color):
-    if not COLOR_RE.fullmatch(color) and color not in COLOR_NAMES:
-        raise ValidationError(_("'{color}' is a bad color value", color=color))
-
 
 def is_not_empty(text):
     if not text.strip():

src/ej_notifications/tests/test_routes.py

@@ -0,0 +1,29 @@
+import pytest
+
+from ej_notifications import routes
+from ej_users.models import User
+
+
+@pytest.fixture
+def user(db):
+    return User.objects.create_user('email@server.com', 'password')
+
+
+class TestRoute:
+    def test_index(self, rf, user):
+        request = rf.get('', {})
+        request.user = user
+        response = routes.index(request)
+        assert response == {
+            'content_title': 'List of notifications',
+            'user': user,
+            'notifications': ['hello', 'world']
+        }
+
+    def test_cluster(self, rf, user):
+        request = rf.get('', {})
+        request.user = user
+        response = routes.clusters(request)
+        assert response == {
+            'user': user,
+        }