Add check if the systemtest was a success. #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-edling
requested review from
a user,
Christoffer-Cortes,
J-Binieda-ericsson,
e-pettersson-ericsson,
henning-roos,
saif-ericsson,
tobiasake and
vasile-baluta
tobiasake
requested changes
Feb 19, 2019
src/systemtest/java/com/ericsson/ei/systemtest/utils/StepsUtils.java
Outdated
Show resolved
Hide resolved
src/systemtest/java/com/ericsson/ei/systemtest/artifactflow/ArtifactFlowSteps.java
Outdated
Show resolved
Hide resolved
erik-edling
commented
Feb 20, 2019
| .addBuildParameter("TEST_CASE_NAME"); | ||
| String test = jenkinsXmlData.getXmlAsString();*/ | ||
| System.out.println(); |
Contributor
Author
There was a problem hiding this comment.
When @a-breid-ericsson is done with his PR in eiffel-commons, i will change the out commented lines. I won't merge like this :) Don't mind this part
Contributor
Christoffer-Cortes
left a comment
Christoffer-Cortes
left a comment
There was a problem hiding this comment.
Looks good. We talked yesterday about the parameters in jenkins jobs. So maybe add a way to define parameter names in the jenkins job.
erik-edling
force-pushed
the
artifactflow-successful-check
branch
from
0792fba to
6cf8ad8
Compare
Contributor
Author
|
In the latest commit i also made it possible to tell the jobs what parameters they should have(if any) |
Christoffer-Cortes
approved these changes
Feb 22, 2019
e-pettersson-ericsson
approved these changes
Feb 22, 2019
Member
e-pettersson-ericsson
left a comment
e-pettersson-ericsson
left a comment
There was a problem hiding this comment.
Looks good, tested and it works!
tobiasake
approved these changes
Feb 22, 2019
erik-edling
added a commit
that referenced
this pull request
Feb 27, 2019
* Add check if the systemtest was a success. * Systemtests now use jenkins xml data object from eiffel-commons instead of xml file. * Change jenkins job step so that it can take parameters and set them up with different amount of parameters.
erik-edling
added a commit
that referenced
this pull request
Mar 18, 2019
* Add check if the systemtest was a success. * Systemtests now use jenkins xml data object from eiffel-commons instead of xml file. * Change jenkins job step so that it can take parameters and set them up with different amount of parameters.
e-pettersson-ericsson
pushed a commit
that referenced
this pull request
Apr 24, 2019
* Add check if the systemtest was a success. * Systemtests now use jenkins xml data object from eiffel-commons instead of xml file. * Change jenkins job step so that it can take parameters and set them up with different amount of parameters.
erik-edling
added a commit
that referenced
this pull request
May 14, 2019
* Add check if the systemtest was a success. * Systemtests now use jenkins xml data object from eiffel-commons instead of xml file. * Change jenkins job step so that it can take parameters and set them up with different amount of parameters.
erik-edling
added a commit
that referenced
this pull request
Jun 19, 2019
* Add check if the systemtest was a success. * Systemtests now use jenkins xml data object from eiffel-commons instead of xml file. * Change jenkins job step so that it can take parameters and set them up with different amount of parameters.
erik-edling
added a commit
that referenced
this pull request
Jul 10, 2019
* Add check if the systemtest was a success. * Systemtests now use jenkins xml data object from eiffel-commons instead of xml file. * Change jenkins job step so that it can take parameters and set them up with different amount of parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
closes #164
Description of the Change
Add a check that loops and checks if all jenkins jobs has been triggered.
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by:
Erik Edling erik.edling@ericsson.com