Add system groovy #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
ghost
mentioned this pull request
erik-edling
reviewed
Feb 20, 2019
| } | ||
|
|
||
| /** | ||
| * This function adds system groovy script to the XML data. |
Contributor
There was a problem hiding this comment.
Write in this description that only one groovy script may be added,
erik-edling
suggested changes
Feb 20, 2019
Contributor
erik-edling
left a comment
erik-edling
left a comment
There was a problem hiding this comment.
Looks good, got one comment about a javadoc
erik-edling
approved these changes
Feb 20, 2019
tobiasake
suggested changes
Feb 20, 2019
| private static final String GROOVY_SCRIPT_SCRIPT_PLUGIN_VERSION = "2.1"; | ||
| private static final String GROOVY_SCRIPT_SECURITY_PLUGIN_VERSION = "1.51"; | ||
|
|
||
| private String hudsonPluginsGroovyGroovyKey = "hudson.plugins.groovy.Groovy plugin='groovy@%s'"; |
Author
There was a problem hiding this comment.
it reflects the xml node name, it has groovy 2 times.
| public JenkinsXmlData addGrovyScript(String script) { | ||
| String hudsonGroovyKey = "hudson.plugins.groovy.Groovy plugin='groovy@2.1'"; | ||
| boolean hasKeyGroovy = builders.has(hudsonGroovyKey); | ||
| hudsonPluginsGroovyGroovyKey = String.format(hudsonPluginsGroovyGroovyKey, GROOVY_SCRIPT_SCRIPT_PLUGIN_VERSION); |
| */ | ||
| public JenkinsXmlData addSystemGrovyScript(String script, boolean sandbox) throws Exception { | ||
| hudsonPluginGroovySystemGroovyKey = String.format(hudsonPluginGroovySystemGroovyKey, | ||
| GROOVY_SCRIPT_SCRIPT_PLUGIN_VERSION); |
tobiasake
approved these changes
Feb 20, 2019
erik-edling
pushed a commit
to erik-edling/eiffel-commons
that referenced
this pull request
Aug 12, 2019
erik-edling
pushed a commit
to erik-edling/eiffel-commons
that referenced
this pull request
Aug 12, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for system groovy script in the Jenkins xml data
Applicable Issues
Description of the Change
Alternate Designs
Benefits
Possible Drawbacks
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: