Skip to content

Added proxy field and fix interaction with DOM #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eggplants merged 5 commits into from
Dec 29, 2025
Merged

Added proxy field and fix interaction with DOM #288

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
93ca7e1
Added proxy field
Monsterovich Jun 19, 2025
8b53eb7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 19, 2025
77baddc
Merge branch 'master' into feat-proxy
Monsterovich Dec 28, 2025
2c33706
docs: use_dom_submit is obsolete
Monsterovich Dec 28, 2025
20e31e5
core: use better selector for error handling
Monsterovich Dec 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 17 additions & 18 deletions deepl/deepl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

from install_playwright import install
from playwright._impl._errors import Error as PlaywrightError
from playwright.async_api import async_playwright
from playwright.async_api import ProxySettings, async_playwright
from playwright.async_api._generated import Browser, Playwright

from deepl.languages import FR_LANGS, TO_LANGS
Expand Down Expand Up @@ -46,14 +46,16 @@ def __init__(
fr_lang: str,
to_lang: str,
timeout: int = 15000,
proxy: ProxySettings | None = None,

) -> None:
"""Initialize DeepLCLI.

Args:
fr_lang (str): Source language.
to_lang (str): Target language.
timeout (int): Timeout in milliseconds. Default is 15000ms.
use_dom_submit (bool): Use DOM submit instead of URL. Default is False.
proxy (ProxySettings): Use a proxy to access deepl.

Raises:
DeepLCLIError: If the language is not valid.
Expand All @@ -73,6 +75,7 @@ def __init__(
self.translated_to_lang: str | None = None
self.max_length = 1500
self.timeout = timeout
self.proxy = proxy

def translate(self, script: str) -> str:
"""Translate script.
Expand Down Expand Up @@ -125,29 +128,24 @@ async def __translate(self, script: str) -> str:
)

url = "https://www.deepl.com/en/translator"
await page.goto(url)

async with page.expect_response(lambda resp: resp.url == url and resp.request.method == "GET") as resp_info:
await page.goto(url)

response = await resp_info.value

if not response.ok:
error_text = await page.inner_text("body > main > div > p")

msg = f"Page loading failed with status code {response.status}: {error_text}"
raise DeepLCLIError(msg)

try:
page.get_by_role("main")
except PlaywrightError as e:
msg = f"Maybe Time limit exceeded. ({self.timeout} ms)"
raise DeepLCLIPageLoadError(msg) from e

with contextlib.suppress(PlaywrightError):
await page.click("button[id=cookie-banner-lax-close-button]")
await page.wait_for_function(
"""
() => document.querySelector('div[data-testid="chrome-extension-toast"]')
""",
)
await page.evaluate(
"""
document.querySelector(
'div[data-testid="chrome-extension-toast"]',
).querySelector('button').click()
""",
)

await page.locator(
"button[data-testid=translator-source-lang-btn]",
).dispatch_event("click")
Expand Down Expand Up @@ -265,4 +263,5 @@ async def __get_browser(self, p: Playwright) -> Browser:
"--no-zygote",
"--window-size=1920,1080",
],
proxy=self.proxy,
)
Loading